Page MenuHomeFreeBSD
Differential D32645

LinuxKPI: pci.h / linux_pci.c rename pci_driver field
ClosedPublic
Actions

Authored by bz on Oct 25 2021, 5:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 25, 1:30 AM
Unknown Object (File)
Fri, Jul 24, 5:15 PM
Unknown Object (File)
Fri, Jul 24, 2:31 PM
Unknown Object (File)
Wed, Jul 22, 1:39 PM
Unknown Object (File)
Tue, Jul 21, 7:50 PM
Unknown Object (File)
Sun, Jul 19, 9:57 PM
Unknown Object (File)
May 7 2026, 1:57 PM
Unknown Object (File)
May 4 2026, 2:00 AM
View All Files
Subscribers
emaste
• hselasky
imp
manu
x11

Details

Reviewers
• hselasky
manu
Group Reviewers
linuxkpi
Commits
rGcf899348420c: LinuxKPI: pci.h / linux_pci.c rename pci_driver field
Summary

Rename the struct pci_driver {} field got the list_head from links
to node as a driver is actually initialsing this to {} which seems
questionable but it will at least make us match the Linux structure
field name.

According to my investigations this field is not used anywhere outside
our implementation so I consider this MFC-able.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz created this revision.Oct 25 2021, 5:20 PM
Herald added a subscriber: emaste. · View Herald TranscriptOct 25 2021, 5:20 PM
bz requested review of this revision.Oct 25 2021, 5:20 PM
Harbormaster completed remote builds in B42349: Diff 97412.Oct 25 2021, 5:20 PM
bz added a comment.Oct 25 2021, 5:21 PM

I cannot find a "graphics" or "drm" review group; do we have one? The main concern here is not to break drm binary drivers shipped in binary packages when MFCing.

• hselasky accepted this revision.Oct 25 2021, 5:30 PM
• hselasky added a subscriber: • hselasky.

Looks good.

This revision is now accepted and ready to land.Oct 25 2021, 5:30 PM
• hselasky added a comment.Oct 25 2021, 5:30 PM

We have the X11 group.

bz added a subscriber: x11.Oct 25 2021, 5:45 PM
manu accepted this revision.Oct 25 2021, 5:53 PM
manu added a subscriber: manu.

We do not seems to use this in drm.

bz added a comment.Oct 25 2021, 5:55 PM
In D32645#736890, @manu wrote:

We do not seems to use this in drm.

Thanks a lot for confirming so quickly.

Closed by commit rGcf899348420c: LinuxKPI: pci.h / linux_pci.c rename pci_driver field (authored by bz). · Explain WhyOct 25 2021, 8:22 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rGcf899348420c: LinuxKPI: pci.h / linux_pci.c rename pci_driver field.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
2 lines
src/
8 lines

Diff 97432

View Options

sys/compat/linuxkpi/common/include/linux/pci.h

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_pci.c

Loading...