Page MenuHomeFreeBSD

New man page arswitch(4)
ClosedPublic

Authored by felix.the.red_gmail.com on Oct 13 2021, 2:21 AM.

Details

Summary

Created a new man page for arswitch, for PR 211668.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

Thanks for moving this here... It's a lot easier to comment on something like this here than in bz.

share/man/man4/arswitch.4
37–38

I'd delete these, or document them.

84–85

I'd leave this whole section out.

Removed commented section for sysctl.
Removed BUGS section.

Here's a few things I noticed.

share/man/man4/arswitch.4
27

Remember to bump .Dd when this gets commited.

55

This sentence needs to be reworked a bit, as it's missing an article, has RAS Syndrome, and it's not entirely clear what the meaning of it is (so I'm having trouble coming up with suggestions).

58

Is this sentence connected to the above? If it is, the above one should probably end with a comma.

62
66
felix.the.red_gmail.com marked 2 inline comments as done.

Removed examples.
Clarified how arswitch configures the ethernet interface.
Added cross-reference to etherswitchcfg(8) and documented which tags arswitch supports.

This revision is now accepted and ready to land.Oct 16 2021, 5:44 PM

mandoc reported the following minor style issues, which I will fix when committing:

mandoc: share/man/man4/arswitch.4:62:42: STYLE: whitespace at end of input line
mandoc: share/man/man4/arswitch.4:72:14: STYLE: no blank before trailing delimiter: Dv doubletag.
mandoc: share/man/man4/arswitch.4:91:18: STYLE: no blank before trailing delimiter: An Felix Johnson.
This revision was automatically updated to reflect the committed changes.