Differential D32076

pf: fix pagefault in pf_getstatus()
ClosedPublic
Actions

Authored by kp on Sep 23 2021, 8:42 AM.

Details

Reviewers

Group Reviewers

Commits

rG9419d273e471: pf: fix pagefault in pf_getstatus()
rG3c9253c2f6d1: pf: fix pagefault in pf_getstatus()
rGcb13059663e4: pf: fix pagefault in pf_getstatus()

Summary

We can't copyout() while holding a lock, in case it triggers a page
fault.
Release the lock before copyout, which is safe because we've already
copied all the data into the nvlist.

PR: 258601
MFC after: 1 week
Sponsored by: Modirum MDPay

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Sep 23 2021, 8:42 AM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptSep 23 2021, 8:42 AM

kp requested review of this revision.Sep 23 2021, 8:42 AM

Harbormaster completed remote builds in B41662: Diff 95551.Sep 23 2021, 8:42 AM

mjg accepted this revision.Sep 23 2021, 12:50 PM

This revision is now accepted and ready to land.Sep 23 2021, 12:50 PM

Closed by commit rGcb13059663e4: pf: fix pagefault in pf_getstatus() (authored by kp). · Explain WhySep 23 2021, 7:58 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGcb13059663e4: pf: fix pagefault in pf_getstatus().

kp added a commit: rG3c9253c2f6d1: pf: fix pagefault in pf_getstatus().Sep 30 2021, 12:22 PM

kp added a commit: rG9419d273e471: pf: fix pagefault in pf_getstatus().

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_ioctl.c

3 lines

Diff 95582

View Options

pf: fix pagefault in pf_getstatus()ClosedPublicActions