Page MenuHomeFreeBSD

sdhci: Fix crash caused by M_WAITOK in sdhci dumps
ClosedPublic

Authored by bag_semihalf.com on Sep 23 2021, 8:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 21, 11:32 PM
Unknown Object (File)
Fri, Mar 20, 3:28 PM
Unknown Object (File)
Thu, Mar 12, 11:28 PM
Unknown Object (File)
Wed, Mar 11, 2:13 PM
Unknown Object (File)
Sun, Mar 8, 1:11 AM
Unknown Object (File)
Sat, Mar 7, 6:21 PM
Unknown Object (File)
Feb 24 2026, 4:28 PM
Unknown Object (File)
Feb 23 2026, 1:38 PM

Details

Summary

In some contexts it is illegal to wait for memory allocation, causing
kernel panic. By default sbuf_new passes M_WAITOK to malloc,
which caused crashes when sdhci_dumpcaps or sdhci_dumpregs was callend in
non sutiable context.

Add SBUF_NOWAIT flag to sbuf_new to fix this.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bag_semihalf.com created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Oct 5 2021, 4:24 AM
This revision was automatically updated to reflect the committed changes.