Page MenuHomeFreeBSD

sdhci: Fix crash caused by M_WAITOK in sdhci dumps
ClosedPublic

Authored by bag_semihalf.com on Sep 23 2021, 8:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 6, 4:44 AM
Unknown Object (File)
Sep 17 2025, 6:53 PM
Unknown Object (File)
Sep 15 2025, 12:54 AM
Unknown Object (File)
Sep 10 2025, 4:39 AM
Unknown Object (File)
Sep 10 2025, 2:04 AM
Unknown Object (File)
Sep 8 2025, 1:53 PM
Unknown Object (File)
Sep 7 2025, 6:51 AM
Unknown Object (File)
Sep 4 2025, 10:55 PM

Details

Summary

In some contexts it is illegal to wait for memory allocation, causing
kernel panic. By default sbuf_new passes M_WAITOK to malloc,
which caused crashes when sdhci_dumpcaps or sdhci_dumpregs was callend in
non sutiable context.

Add SBUF_NOWAIT flag to sbuf_new to fix this.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bag_semihalf.com created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Oct 5 2021, 4:24 AM
This revision was automatically updated to reflect the committed changes.