src.conf: add a WITH_DTRACE_TESTS option
ClosedPublic
Actions

Authored by markj on Jul 25 2015, 1:39 AM.

Details

Reviewers

ngie
gnn

Commits

rS286174: Add a src.conf option to build and install the DTrace test suite.

Summary

This defaults to off because:

the test suite is not stable on !amd64
some of the userland DTrace test programs can only be built on head

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

markj updated this revision to Diff 7284.Jul 25 2015, 1:39 AM

markj retitled this revision from to src.conf: add a WITH_DTRACE_TESTS option.

markj edited the test plan for this revision. (Show Details)

markj added a reviewer: ngie.

markj updated this object.

Herald added a reviewer: gnn. · View Herald TranscriptJul 25 2015, 1:39 AM

Herald added subscribers: emaste, imp, bdrewery. · View Herald Transcript

gnn accepted this revision.Jul 26 2015, 9:06 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.Jul 26 2015, 9:06 PM

ngie added inline comments.Jul 27 2015, 4:13 AM

cddl/usr.sbin/dtrace/Makefile

27–29

Please make this knob explicitly set to "no" if MK_TESTS == no in src.opts.mk, e.g.

$ svn diff share/mk/src.opts.mk 
Index: share/mk/src.opts.mk
===================================================================
--- share/mk/src.opts.mk	(revision 285904)
+++ share/mk/src.opts.mk	(working copy)
@@ -319,6 +319,10 @@
 MK_AUTHPF:=	no
 .endif
 
+.if ${MK_TESTS} == "no"
+MK_DTRACE_TESTS:=	no
+.endif
+
 .if ${MK_TEXTPROC} == "no"
 MK_GROFF:=	no
 .endif