multimedia/vlc: Enable support for subtitles by default and add missing deps
ClosedPublic
Actions

Authored by diizzy on Sep 6 2021, 12:44 PM.

Details

Reviewers

tcberner
arrowd
lbartoletti

Group Reviewers

multimedia

Commits

R11:fe3ca40c7e29: multimedia/vlc: Enable support for subtitles and add missing deps

Summary

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256593

Test Plan

Poudriere testport OK 12.2-RELEASE (amd64)

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

diizzy requested review of this revision.Sep 6 2021, 12:44 PM

diizzy created this revision.

Changes looks fine, although I'm bit unsure about --disable-mpg123 and iconv:wchar_t parts. Can you explain them?

By default the configure script will autodetect (lib)mpg123 (if available) which causes a dependency mismatch since it's not defined. As for functionality it's redundant because of ffmpeg and normally doesn't get pulled in. To be honest I don't know exactly what settings Philipp used but I can try to track it down however it's most likely due to a non standard option in some dependency.
Regarding iconv:wchar_t this was added in the patch Philipp submitted ( https://bugs.freebsd.org/bugzilla/attachment.cgi?id=226246 ) and grepping VLC's source code showed a few instances where it was used.

arrowd accepted this revision.Sep 6 2021, 5:45 PM

This revision is now accepted and ready to land.Sep 6 2021, 5:45 PM

Closed by commit R11:fe3ca40c7e29: multimedia/vlc: Enable support for subtitles and add missing deps (authored by diizzy). · Explain WhySep 6 2021, 6:22 PM

This revision was automatically updated to reflect the committed changes.

diizzy added a commit: R11:fe3ca40c7e29: multimedia/vlc: Enable support for subtitles and add missing deps.