Differential D31627

Allow LIO_READV and LIO_WRITEV in lio_listio().
ClosedPublic
Actions

Authored by tmunro on Aug 21 2021, 3:07 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 19, 3:32 PM

	Unknown Object (File)
	Tue, Nov 19, 3:32 PM

	Unknown Object (File)
	Tue, Nov 19, 3:32 PM

	Unknown Object (File)
	Tue, Nov 19, 2:34 PM

	Unknown Object (File)
	Wed, Nov 13, 6:54 PM

	Unknown Object (File)
	Oct 22 2024, 4:25 AM

	Unknown Object (File)
	Oct 17 2024, 4:14 PM

	Unknown Object (File)
	Oct 5 2024, 8:23 AM

Subscribers

Details

Reviewers

Commits

rG05bfa3e05896: lio_listio(2): Allow LIO_READV and LIO_WRITEV.
rGf30a1ae8d529: lio_listio(2): Allow LIO_READV and LIO_WRITEV.

Summary

Allow multiple vector IOs to be started with one system call. The aio_readv() and aio_writev() functions already used the same code as lio_listio() under the covers. This commit just exposes the formerly internal-only LIO_READV and LIO_WRITEV opcodes to user space.

The new opcode are only visible to user space if __BSD_VISIBLE is defined, being extensions to POSIX, just like the aio_readv() and aio_writev() functions.

The other obvious candidate is LIO_SYNC, but that involves answering some tricky questions about dependencies and is left for later.

I subscribed the reviewers of D27743 (aio_readv() and aio_writev()).

Test Plan

A simple kyua test is included.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tmunro requested review of this revision.Aug 21 2021, 3:07 AM

tmunro created this revision.

Reuploaded patch with -U99999, no change.

Don't forget to bump the date in the man page.

tests/sys/aio/lio_test.c
230	The ftruncate is not necessary, since Kyua will always run the test in a brand-new directory.

This revision now requires changes to proceed.Aug 21 2021, 4:23 AM

tmunro updated this revision to Diff 93993.Aug 21 2021, 4:47 AM

tmunro marked an inline comment as done.

asomers accepted this revision.Aug 21 2021, 1:25 PM

This revision is now accepted and ready to land.Aug 21 2021, 1:25 PM

kib added inline comments.Aug 21 2021, 1:56 PM

lib/libc/sys/lio_listio.2
231	s/FreeeBSD/.Fx/

Closed by commit rGf30a1ae8d529: lio_listio(2): Allow LIO_READV and LIO_WRITEV. (authored by tmunro). · Explain WhyAug 22 2021, 11:05 AM

This revision was automatically updated to reflect the committed changes.

tmunro added a commit: rGf30a1ae8d529: lio_listio(2): Allow LIO_READV and LIO_WRITEV..

tmunro marked an inline comment as done.Aug 22 2021, 11:06 AM

jhb added a commit: rG05bfa3e05896: lio_listio(2): Allow LIO_READV and LIO_WRITEV..Sep 6 2023, 9:57 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 6 2023, 9:57 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

sys/

15 lines

sys/

kern/

4 lines

sys/

4 lines

tests/

sys/

aio/

109 lines

usr.bin/

truss/

2 lines

Diff 93993

lib/libc/sys/lio_listio.2

Loading...

sys/kern/vfs_aio.c

Loading...

sys/sys/aio.h

Loading...

tests/sys/aio/lio_test.c

Loading...

usr.bin/truss/syscalls.c

Loading...