There are still reports of people with old systems running into issues on pkg upgrade. I think libglvnd must be a LIB_DEPEND in the main branch now to help with dependency solving.
Details
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
I forgot to add USES+=gl, but even with that the LIB_DEPENDS wasn't working as expected. Convert to explicit LIB_DEPENDS.
Looks OK (except inline nits):
- www/qt5-webengine and all of its dependencies still build fine
- x11/alacritty + emulators/yuzu-qt5 still install/run fine
graphics/mesa-devel/Makefile | ||
---|---|---|
29 | Sort by port origin instead of the library name for consistency with current style here and my other ports. I don't agree with everything portlint -C, portfmt or portclippy suggest. | |
graphics/mesa-libs/Makefile | ||
9–10 | Why += instead of =? .include appears at the end of this Makefile which itself isn't sourced/included unlike mesa-dri/Makefile.common. | |
graphics/s2tc/Makefile | ||
13–14 | Neither an OpenGL provider nor requires libOpenGL at runtime. Disabling dlopen via CONFIGURE_ARGS=--disable-runtime-linking exposes libtxc_dxtn.so in poudriere testport output but not libOpenGL, suggesting only headers are used. Try the following smoke test: $ pkg install s2tc $ pkg delete -f libglvnd $ pkg info -l s2tc | sed -n '/bin/p; /lib\//p' | xargs strings | grep GL.\*so $ fetch https://people.math.sc.edu/Burkardt/data/tga/earth.tga $ s2tc_compress -i earth.tga -o earth.dds -t DXT5 $ file earth.dds earth.dds: Microsoft DirectDraw Surface (DDS): 512 x 512, compressed using DXT5 |
On landing maybe bump PORTREVISION in the modified ports to make upgrades more predictable (e.g., for portmaster users) and discover fallout early (if any but unlikely).