Differential D31409

sdhci_xenon: remove redundant code in property parsing
ClosedPublic
Actions

Authored by bag_semihalf.com on Aug 4 2021, 8:18 AM.

Tags

None

Referenced Files

	F166262133: D31409.id.diff
	Wed, Aug 12, 2:49 PM

	Unknown Object (File)
	Mon, Aug 10, 4:02 AM

	Unknown Object (File)
	Sat, Aug 8, 12:55 AM

	Unknown Object (File)
	Fri, Aug 7, 9:58 AM

	Unknown Object (File)
	Tue, Aug 4, 6:52 AM

	Unknown Object (File)
	Tue, Aug 4, 6:30 AM

	Unknown Object (File)
	Mon, Aug 3, 8:13 AM

	Unknown Object (File)
	Sat, Jul 25, 3:55 PM

Subscribers

dgr_semihalf.com

Details

Reviewers

mw
mmel
manu

Commits

rG1b19617e9662: sdhci_xenon: remove redundant code in property parsing
rG6ad816a99917: sdhci_xenon: remove redundant code in property parsing

Summary

Remove redundant ofw property parsing in driver code, is already
taken care of in mmc_fdt_helpers.

Move ofw parsing to attach method.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bag_semihalf.com requested review of this revision.Aug 4 2021, 8:18 AM

bag_semihalf.com created this revision.

bag_semihalf.com added a parent revision: D31408: mmc_fdt_helper: correct typo in dts property name 'no-1-8-v'.

LGTM + tested on MacchiatoBin/CN913x-DB/CN913x-CEx7-Evaluation board

This revision is now accepted and ready to land.Aug 13 2021, 3:14 PM

manu accepted this revision.Aug 15 2021, 2:04 PM

Closed by commit rG6ad816a99917: sdhci_xenon: remove redundant code in property parsing (authored by bag_semihalf.com, committed by mw). · Explain WhyAug 17 2021, 7:04 AM

This revision was automatically updated to reflect the committed changes.

mw added a commit: rG6ad816a99917: sdhci_xenon: remove redundant code in property parsing.

mw added a commit: rG1b19617e9662: sdhci_xenon: remove redundant code in property parsing.Mar 7 2022, 4:00 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 7 2022, 4:00 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sdhci/

69 lines

Diff 93808

sys/dev/sdhci/sdhci_xenon.c

Loading...