Page MenuHomeFreeBSD
Differential D31397

pkgbase: move locales into their own package
ClosedPublic
Actions

Authored by bapt on Aug 3 2021, 3:03 PM.
Tags
None
Referenced Files
F132263414: D31397.id93173.diff
Wed, Oct 15, 7:34 AM
Unknown Object (File)
Sat, Oct 4, 7:40 PM
Unknown Object (File)
Fri, Sep 26, 5:00 AM
Unknown Object (File)
Thu, Sep 25, 2:39 AM
Unknown Object (File)
Wed, Sep 24, 12:37 PM
Unknown Object (File)
Sun, Sep 21, 11:23 PM
Unknown Object (File)
Mon, Sep 15, 10:51 PM
Unknown Object (File)
Sep 15 2025, 12:06 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
manu
emaste
Group Reviewers
pkgbase
Commits
rG0fa5403d493b: pkgbase: move locales into their own package
Summary

The only exception here being C.UTF-8

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bapt created this revision.Aug 3 2021, 3:03 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 3 2021, 3:03 PM
bapt requested review of this revision.Aug 3 2021, 3:03 PM
Harbormaster completed remote builds in B40826: Diff 93172.Aug 3 2021, 3:03 PM
emaste added a subscriber: emaste.Aug 3 2021, 3:08 PM

I like this change very much.

Maybe share/ctypedef/Makefile deserves a comment explaining why it's a special case?

bapt updated this revision to Diff 93173.Aug 3 2021, 3:12 PM

Add a comment for C.UTF-8

Harbormaster completed remote builds in B40827: Diff 93173.Aug 3 2021, 3:12 PM
emaste added inline comments.Aug 3 2021, 3:16 PM
share/ctypedef/Makefile
234

also should this be runtime?

For CI boot smoke test (tools/boot/ci-qemu-test.sh) I have found that I can get away with just:

  • FreeBSD-kernel-generic
  • FreeBSD-bootloader
  • FreeBSD-clibs
  • FreeBSD-runtime

(with a few warnings emitted on the console) admittedly just about any usable FreeBSD install will have -utilities installed but it appears there are bare minimal cases that can get away with just -runtime

bapt updated this revision to Diff 93174.Aug 3 2021, 3:18 PM

Change the C.UTF-8 package to runtime

Harbormaster completed remote builds in B40828: Diff 93174.Aug 3 2021, 3:18 PM
bapt marked an inline comment as done.Aug 3 2021, 3:18 PM
emaste accepted this revision.Aug 3 2021, 3:41 PM
This revision is now accepted and ready to land.Aug 3 2021, 3:41 PM
bapt updated this revision to Diff 93181.Aug 3 2021, 4:10 PM

rebase

This revision now requires review to proceed.Aug 3 2021, 4:10 PM
Harbormaster completed remote builds in B40831: Diff 93181.Aug 3 2021, 4:10 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 3 2021, 4:37 PM
Closed by commit rG0fa5403d493b: pkgbase: move locales into their own package (authored by bapt). · Explain Why
This revision was automatically updated to reflect the committed changes.
bapt added a commit: rG0fa5403d493b: pkgbase: move locales into their own package.

Revision Contents
Changeset List

PathSize
share/
colldef/
1 line
colldef_unicode/
2 lines
ctypedef/
9 lines
monetdef/
2 lines
monetdef_unicode/
2 lines
msgdef/
2 lines
msgdef_unicode/
2 lines
numericdef/
2 lines
numericdef_unicode/
2 lines
timedef/
2 lines
tools/
tools/
locale/
tools/
2 lines

Diff 93183

View Options

share/colldef/Makefile

Loading...
View Options

share/colldef_unicode/Makefile

Loading...
View Options

share/ctypedef/Makefile

Loading...
View Options

share/monetdef/Makefile

Loading...
View Options

share/monetdef_unicode/Makefile

Loading...
View Options

share/msgdef/Makefile

Loading...
View Options

share/msgdef_unicode/Makefile

Loading...
View Options

share/numericdef/Makefile

Loading...
View Options

share/numericdef_unicode/Makefile

Loading...
View Options

share/timedef/Makefile

Loading...
View Options

tools/tools/locale/tools/cldr2def.pl

Loading...