dummynet: fix sysctls
ClosedPublic
Actions

Authored by kp on Jul 1 2021, 9:46 AM.

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rG1975b8347df6: dummynet: fix sysctls
rGaae1a783dd44: dummynet: fix sysctls
rG8f76eebce424: dummynet: fix sysctls

Summary

The sysctl nodes which use V_dn_cfg must be marked as CTLFLAG_VNET so
that we use the correct per-vnet offset

PR: 256819
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40205
Build 37094: arc lint + arc unit

Event Timeline

kp created this revision.Jul 1 2021, 9:46 AM

Herald added subscribers: donner, melifaro, ae, imp. · View Herald TranscriptJul 1 2021, 9:46 AM

kp requested review of this revision.Jul 1 2021, 9:46 AM

Harbormaster completed remote builds in B40204: Diff 91601.Jul 1 2021, 9:46 AM

Remove unintended changes

Harbormaster completed remote builds in B40205: Diff 91602.Jul 1 2021, 9:47 AM

Tested on stable/13. Affected counters work fine again after applying the patch.
Thank you for the fix.

donner accepted this revision as: donner.Jul 1 2021, 1:02 PM

This revision is now accepted and ready to land.Jul 1 2021, 1:02 PM

Closed by commit rG8f76eebce424: dummynet: fix sysctls (authored by kp). · Explain WhyJul 1 2021, 7:35 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG8f76eebce424: dummynet: fix sysctls.

kp added a commit: rGaae1a783dd44: dummynet: fix sysctls.Jul 8 2021, 11:50 AM

kp added a commit: rG1975b8347df6: dummynet: fix sysctls.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

ip_dn_io.c

38 lines

Diff 91602

View Options

sys/netpfil/ipfw/ip_dn_io.c

dummynet: fix sysctlsClosedPublicActions