Paths

Table of Contentst

Differential D30876

arm64: replace pa_to_pvh() with page_to_pvh() in pmap_remove_l2()
ClosedPublic
Actions

Authored by alc on Jun 23 2021, 8:01 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 18, 1:13 AM

	Unknown Object (File)
	Mon, May 18, 1:13 AM

	Unknown Object (File)
	Mon, May 18, 12:51 AM

	Unknown Object (File)
	Wed, Apr 29, 5:33 AM

	Unknown Object (File)
	Wed, Apr 29, 5:28 AM

	Unknown Object (File)
	Tue, Apr 28, 11:11 PM

	Unknown Object (File)
	Tue, Apr 28, 11:06 PM

	Unknown Object (File)
	Tue, Apr 28, 5:09 PM

Subscribers

Details

Reviewers

andrew
kib
markj
manu

Commits

rG0c188c06c627: arm64: replace pa_to_pvh() with page_to_pvh() in pmap_remove_l2()

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alc created this revision.Jun 23 2021, 8:01 AM

Herald added a reviewer: manu. · View Herald TranscriptJun 23 2021, 8:01 AM

Herald added a subscriber: emaste. · View Herald Transcript

alc requested review of this revision.Jun 23 2021, 8:01 AM

kib accepted this revision.Jun 23 2021, 9:55 AM

This revision is now accepted and ready to land.Jun 23 2021, 9:55 AM

markj accepted this revision.Jun 23 2021, 12:56 PM

markj added inline comments.

sys/arm64/arm64/pmap.c
2859	We use `Ln_ENTRIES` instead of `L2_SIZE / PAGE_SIZE` elsewhere, but it's not really consistent within the pmap.

alc added inline comments.Jun 24 2021, 3:25 AM

sys/arm64/arm64/pmap.c
2859	I believe that we are using Ln_ENTRIES when iterating over page table entries and L2_SIZE / PAGE_SIZE when iterating over vm_pages.

Closed by commit rG0c188c06c627: arm64: replace pa_to_pvh() with page_to_pvh() in pmap_remove_l2() (authored by alc). · Explain WhyJun 24 2021, 3:38 AM

This revision was automatically updated to reflect the committed changes.

alc added a commit: rG0c188c06c627: arm64: replace pa_to_pvh() with page_to_pvh() in pmap_remove_l2().

Revision Contents
Changeset List

Path

Size

sys/

arm64/

arm64/

18 lines

Diff 91301

sys/arm64/arm64/pmap.c

Loading...