Page MenuHomeFreeBSD
Differential D30876

arm64: replace pa_to_pvh() with page_to_pvh() in pmap_remove_l2()
ClosedPublic
Actions

Authored by alc on Jun 23 2021, 8:01 AM.
Tags
None
Referenced Files
F168892421: D30876.id91256.diff
Sun, Aug 30, 3:36 PM
F168883270: D30876.id.diff
Sun, Aug 30, 2:41 PM
F168877546: D30876.diff
Sun, Aug 30, 2:01 PM
Unknown Object (File)
Mon, Aug 24, 3:07 PM
Unknown Object (File)
Mon, Aug 24, 2:58 PM
Unknown Object (File)
Wed, Aug 19, 4:14 PM
Unknown Object (File)
Tue, Aug 18, 9:36 PM
Unknown Object (File)
Tue, Aug 18, 9:32 PM
View All Files
Subscribers
emaste

Details

Reviewers
andrew
kib
markj
manu
Commits
rG0c188c06c627: arm64: replace pa_to_pvh() with page_to_pvh() in pmap_remove_l2()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alc created this revision.Jun 23 2021, 8:01 AM
Herald added a reviewer: manu. · View Herald TranscriptJun 23 2021, 8:01 AM
Herald added a subscriber: emaste. · View Herald Transcript
alc requested review of this revision.Jun 23 2021, 8:01 AM
kib accepted this revision.Jun 23 2021, 9:55 AM
This revision is now accepted and ready to land.Jun 23 2021, 9:55 AM
markj accepted this revision.Jun 23 2021, 12:56 PM
markj added inline comments.
sys/arm64/arm64/pmap.c
2859

We use Ln_ENTRIES instead of L2_SIZE / PAGE_SIZE elsewhere, but it's not really consistent within the pmap.

alc added inline comments.Jun 24 2021, 3:25 AM
sys/arm64/arm64/pmap.c
2859

I believe that we are using Ln_ENTRIES when iterating over page table entries and L2_SIZE / PAGE_SIZE when iterating over vm_pages.

Closed by commit rG0c188c06c627: arm64: replace pa_to_pvh() with page_to_pvh() in pmap_remove_l2() (authored by alc). · Explain WhyJun 24 2021, 3:38 AM
This revision was automatically updated to reflect the committed changes.
alc added a commit: rG0c188c06c627: arm64: replace pa_to_pvh() with page_to_pvh() in pmap_remove_l2().

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
18 lines

Diff 91301

View Options

sys/arm64/arm64/pmap.c

Loading...