fusefs: improve warnings about buggy FUSE servers
ClosedPublic
Actions

Authored by asomers on Jun 15 2021, 9:41 PM.

Details

Reviewers

emaste
pfg

Commits

rGba99ff623b80: fusefs: improve warnings about buggy FUSE servers
rGcc5020854d96: fusefs: improve warnings about buggy FUSE servers
rG0b9a5c6fa173: fusefs: improve warnings about buggy FUSE servers

Summary

The fusefs driver will print warning messages about FUSE servers that
commit protocol violations. Previously it would print those warnings on
every violation, but that could spam the console. Now it will print
each warning no more than once per lifetime of the mount. There is also
now a dtrace probe for each violation.

MFC after: 2 weeks
Sponsored by: Axcient

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Jun 15 2021, 9:41 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 15 2021, 9:41 PM

asomers requested review of this revision.Jun 15 2021, 9:41 PM

Harbormaster completed remote builds in B39924: Diff 90931.Jun 15 2021, 9:41 PM

pfg accepted this revision.Jun 16 2021, 6:01 PM

This revision is now accepted and ready to land.Jun 16 2021, 6:01 PM

I like this idea.

I'd like us to apply the same concept to the Linuxulator, for similar types of warnings (although in Linuxulator the spammy warnings are for unimplemented kernel functionality).

sys/fs/fuse/fuse_internal.c
917–918	This change seems to be un-style(9)ing
sys/fs/fuse/fuse_ipc.h
236–240	might we end up with enough distinct warnings to run out of flag bits? (just add a second flags field if/when that happens?)

asomers marked 2 inline comments as done.Jun 16 2021, 6:37 PM

asomers added inline comments.

sys/fs/fuse/fuse_internal.c
917–918	Ok, I'll revert this line.
sys/fs/fuse/fuse_ipc.h
236–240	Yep, but the flags field never leaves this module. So we can add more fields or reassign bits at will.