Page MenuHomeFreeBSD

Add schilytools port comprising 10 ports
Needs ReviewPublic

Authored by fuz_fuz.su on Mon, Jun 7, 12:36 PM.

Details

Reviewers
mm
marius
makc
Summary

In 2018, Jörg Schilling consolidated all his projects into the
schilytools project and stopped providing new separate releases for the
individual projects (such as cdrtools, smake, star, and ved). Hence,
the FreeBSD ports of these projects have been stuck on outdated versions
for years.

With this changeset, the schilytools are added to the ports collection
as a collection of 10 ports:

devel/schilybase (libraries)
archivers/star
devel/sccs
devel/smake
devel/sunpromake
editors/ved
net/rscsi (split out from cdrtools for security reasons)
sysutils/cdrtools
sysutils/schilyutils (command line helpers, shells)
misc/schilytools (meta port for all of these)

Where appropriate, I've tried to keep existing patches and conventions
in tact. Some options have been renamed to more appropriate names,
others have been added or removed. The schilytools have been patched
not to install binaries with the same name as system binaries, though
some man pages with such names remain.

The split into slave ports largely follows the OpenCSW packages provided
by the author. Some differences are present:

  • strar has been moved from schilyutils to star
  • rscsi has been moved from cdrtools into a package on its own as it needs to be installed setuid to function.
  • mountcd is a Solaris only program and is not shipped
  • man2html is not shipped as it's already available in textproc/man2html
  • cdrecord, cdda2wav, and readcd are only installed setuid root if the user specifically requests so using a non-default option

This changeset unobsoletes the editors/ved port.

This changeset obsoletes the sysutils/cdrtools-devel port as schilytools
provide a newer version than the old development version shipped therein.

This changeset obsoletes the sysutils/sformat port as sformat is now
included in sysutils/schilyutils. If desired, I can split it back out into a
port on its own.

This changeset overwrites the following ports, the maintainers have
previously been informed via PR and direct email but haven't responded.
They have also been added as reviewers to this changeset.

archivers/star (mm@freebsd.org)
devel/smake (no maintainer)
sysutils/cdrtools (marius@freebsd.org)
sysutils/cdrtools-devel (marius@freebsd.org)
sysutils/sformat (marius@freebsd.org)

I'm willing to take over maintainership for these ports.

Test Plan

Tested with poudriere on 13.0-RELEASE amd64, i386, armv7, and amd64.
Portlint doesn't really like the way I set up the slave ports but
otherwise doesn't complain too much. I'd appreciate some manual
reviews of the way the ports are set up.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 39912
Build 36801: arc lint + arc unit

Event Timeline

archivers/star: do not install an mt binary

A last minute change I somehow forgot to include.

sysutils/sformat: obsolete; subsumed under sysutils/schilyutils

sformat is included in sysutils/schilyutils. I was unaware that
a port already exists. The maintainer of that port, marius@freebsd.org
is already subscribed to this differential revision.

archivers/star: simplify Makefile

This applies code review feedback by nimaje from the #freebsd-ports IRC channel on libera.chat

archivers/star/Makefile
16

That is being too clever. Never trade readability with optimization.

Using this is probably better:

TARTEST_VARS=  COMPONENTS+=tartest
archivers/star/Makefile
6–9

This can be removed.

sysutils/cdrtools/Makefile
6–18

address code review feedback by mat

This change set applies all fixes requested by mat.