Page MenuHomeFreeBSD
Differential D30615

kmod.mk: Allow extra objects to be specified in modules
ClosedPublic
Actions

Authored by imp on Jun 2 2021, 4:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 22, 1:11 AM
Unknown Object (File)
Tue, Sep 22, 1:11 AM
Unknown Object (File)
Tue, Sep 22, 1:10 AM
Unknown Object (File)
Tue, Sep 22, 1:08 AM
Unknown Object (File)
Thu, Sep 10, 10:16 PM
Unknown Object (File)
Tue, Sep 8, 7:11 PM
Unknown Object (File)
Sun, Sep 6, 3:33 PM
Unknown Object (File)
Sat, Sep 5, 3:47 PM
View All Files
Subscribers
emaste

Details

Reviewers
emaste
Commits
rGe8dca53aa06e: kmod.mk: Allow extra objects to be specified in modules
Summary

OBJS are automatically added to CLEANFILES. For pre-built objects, this
is not desirable since it will delete the object from the source
tree. Introduce EXTRA_OBJS which list these object files, but aren't
added to clean files.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jun 2 2021, 4:18 PM
imp created this revision.
Harbormaster completed remote builds in B39665: Diff 90325.Jun 2 2021, 4:18 PM
emaste accepted this revision.Jun 2 2021, 4:25 PM
emaste added a subscriber: emaste.

LGTM modulo discussions happening on IRC around the variable name.

This revision is now accepted and ready to land.Jun 2 2021, 4:25 PM
imp updated this revision to Diff 90327.Jun 2 2021, 4:29 PM

ed's commments use BLOB_OBJS and document it.

This revision now requires review to proceed.Jun 2 2021, 4:29 PM
Harbormaster completed remote builds in B39667: Diff 90327.Jun 2 2021, 4:30 PM
emaste accepted this revision.Jun 2 2021, 4:31 PM

Macro shipit:

This revision is now accepted and ready to land.Jun 2 2021, 4:31 PM
Closed by commit rGe8dca53aa06e: kmod.mk: Allow extra objects to be specified in modules (authored by imp). · Explain WhyJun 2 2021, 4:40 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGe8dca53aa06e: kmod.mk: Allow extra objects to be specified in modules.

Revision Contents
Changeset List

PathSize
sys/
conf/
14 lines

Diff 90330

View Options

sys/conf/kmod.mk

Loading...