Page MenuHomeFreeBSD

[skip ci] add a CODEOWNERS file
ClosedPublic

Authored by asomers on May 30 2021, 9:57 PM.

Details

Summary

Convert MAINTAINERS into a Github CODEOWNERS file. This will
automatically assign reviewers to some GH pull requests. The conversion
is not 1:1; some committers don't have Github accounts (e.g. adrian),
some functional areas don't neatly correspond to a set of files (e.g.
kqueue), and mailing lists can't be assigned as a reviewer (e.g.
secteam@). But it's a start.

MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I love this, though in time we may need to change the usernames a little depending on where we land.

For now, this is great, since we don't have pull requests turned on in gitlab that I can see.

In the fullness of time, I'd love to see this autogenerated in part based on who has touched the files "lately" for the more active parts of the tree and add them as well. But that's in no way even close to a requirement today.

This also points out a problem with any migration to any platform: what to do about username, etc. Also not a problem here, but since you did the work to get us this far it adds to the list of issues we'll need an answer for. :)

This revision is now accepted and ready to land.May 30 2021, 10:18 PM
In D30559#686263, @imp wrote:

I love this, though in time we may need to change the usernames a little depending on where we land.

For now, this is great, since we don't have pull requests turned on in gitlab that I can see.

Wait, what? Do we already have a gitlab instance somewhere?

In the fullness of time, I'd love to see this autogenerated in part based on who has touched the files "lately" for the more active parts of the tree and add them as well. But that's in no way even close to a requirement today.

This also points out a problem with any migration to any platform: what to do about username, etc. Also not a problem here, but since you did the work to get us this far it adds to the list of issues we'll need an answer for. :)

This revision was automatically updated to reflect the committed changes.

Wait, what? Do we already have a gitlab instance somewhere?

We publish to gitlab.com

In D30559#686274, @imp wrote:

Wait, what? Do we already have a gitlab instance somewhere?

We publish to gitlab.com

github.com ?

In D30559#686588, @ceri wrote:
In D30559#686274, @imp wrote:

Wait, what? Do we already have a gitlab instance somewhere?

We publish to gitlab.com

github.com ?

We publish to both, and others as well, from the central cgit repo today, including gitlab.com, where one can do gitlab things with your freebsd, should you want to.