Page MenuHomeFreeBSD
Differential D30469

getnetent(3): Add missing reentrant functions
ClosedPublic
Actions

Authored by fernape on May 26 2021, 2:40 PM.
Tags
None
Referenced Files
F152810698: D30469.id107179.diff
Fri, Apr 17, 6:34 AM
F152787179: D30469.id89909.diff
Fri, Apr 17, 2:53 AM
F152775510: D30469.id.diff
Fri, Apr 17, 1:02 AM
Unknown Object (File)
Sat, Apr 11, 4:06 PM
Unknown Object (File)
Wed, Apr 8, 6:23 AM
Unknown Object (File)
Mon, Apr 6, 2:23 PM
Unknown Object (File)
Sun, Apr 5, 8:02 PM
Unknown Object (File)
Sun, Mar 22, 3:18 PM
View All Files
Subscribers
asomers
imp
pauamma_gundo.com

Details

Reviewers
0mp
gbe
imp
pauamma_gundo.com
Group Reviewers
manpages
Commits
rGa3c3c02244f4: getnetent(3): Add missing reentrant functions
rGdc68997328ec: getnetent(3): Add missing reentrant functions
Summary

Add documentation for getnetent_r, getnetbyaddr_r and getnetbyname_r

Create proper MLINKs for the new functions.

PR: 249154
Reported by: asomers@

Test Plan

Same as in https://reviews.freebsd.org/D30385

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fernape created this revision.May 26 2021, 2:40 PM
Herald added a reviewer: manpages. · View Herald TranscriptMay 26 2021, 2:40 PM
Herald added a subscriber: imp. · View Herald Transcript
fernape requested review of this revision.May 26 2021, 2:40 PM
Harbormaster completed remote builds in B39463: Diff 89909.May 26 2021, 2:40 PM
fernape updated this revision to Diff 106867.Jun 13 2022, 4:02 PM

Add .Nm entries.

Harbormaster completed remote builds in B45958: Diff 106867.Jun 13 2022, 4:02 PM
fernape added a comment.Jun 13 2022, 4:02 PM

Can I have some feedback here so I can move forward with this?

imp accepted this revision.Jun 13 2022, 8:28 PM

same, seems reasonable

This revision is now accepted and ready to land.Jun 13 2022, 8:28 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.Jun 16 2022, 12:15 AM
pauamma_gundo.com added inline comments.
lib/libc/net/gethostbyname.3
43–45

Should all the *_r functions be kept together, or each moved next to the corresponding non-reentrant function?

68–73

Same question as above.

fernape added inline comments.Jun 16 2022, 6:04 AM
lib/libc/net/gethostbyname.3
43–45

I would keep them together. See cap_endgrent(3), cap_pwd(3)

pauamma_gundo.com accepted this revision.Jun 17 2022, 4:10 AM
pauamma_gundo.com added inline comments.
lib/libc/net/gethostbyname.3
43–45

WFM. Consistency in outline with other manual pages is as good an answer as any.

Closed by commit rGdc68997328ec: getnetent(3): Add missing reentrant functions (authored by fernape). · Explain WhyJun 20 2022, 5:31 AM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: rGdc68997328ec: getnetent(3): Add missing reentrant functions.
gbe added a commit: rGa3c3c02244f4: getnetent(3): Add missing reentrant functions.Sep 24 2022, 8:13 AM

Revision Contents
Changeset List

PathSize
lib/
libc/
net/
7 lines
33 lines

Diff 107179

View Options

lib/libc/net/Makefile.inc

Loading...
View Options

lib/libc/net/gethostbyname.3

Loading...