rack: honor prior socket buffer lock when doing the upcall
ClosedPublic
Actions

Authored by rscheff on May 21 2021, 9:30 PM.

Details

Reviewers

rrs
tuexen
jtl

Group Reviewers

transport

Commits

rG0230e6cf56eb: rack: honor prior socket buffer lock when doing the upcall
rG39756885633f: rack: honor prior socket buffer lock when doing the upcall

Summary

While partially reverting D24237 with D29690, due to introducing some
unintended effects for in-kernel TCP consumers, the preexisting lock
on the socket send buffer was not considered properly.

Test Plan

Found by: markj
MFC: 2 weeks
Sponsored by: NetApp, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rscheff created this revision.May 21 2021, 9:30 PM

Herald added a reviewer: transport. · View Herald TranscriptMay 21 2021, 9:30 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.May 21 2021, 9:30 PM

Harbormaster completed remote builds in B39347: Diff 89628.May 21 2021, 9:30 PM

tuexen accepted this revision.May 21 2021, 9:54 PM

This revision is now accepted and ready to land.May 21 2021, 9:54 PM

Closed by commit rG39756885633f: rack: honor prior socket buffer lock when doing the upcall (authored by rscheff). · Explain WhyMay 21 2021, 10:16 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rG39756885633f: rack: honor prior socket buffer lock when doing the upcall.

rscheff added a commit: rG0230e6cf56eb: rack: honor prior socket buffer lock when doing the upcall.Jun 9 2021, 11:14 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

rack.c

4 lines

Diff 89636

View Options

sys/netinet/tcp_stacks/rack.c

rack: honor prior socket buffer lock when doing the upcallClosedPublicActions