dummynet: free(NULL, M_DUMMYNET); is safe
ClosedPublic
Actions

Authored by kp on May 21 2021, 3:14 PM.

Details

Reviewers

Group Reviewers

Commits

rG932531232a9d: dummynet: free(NULL, M_DUMMYNET); is safe
rG719f6456fbde: dummynet: free(NULL, M_DUMMYNET); is safe
rG1b2dbe37fa32: dummynet: free(NULL, M_DUMMYNET); is safe

Summary

There's no need to check pointers for NULL before free()ing them.

No functional change.

MFC after: 2 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39338
Build 36227: arc lint + arc unit

Event Timeline

kp created this revision.May 21 2021, 3:14 PM

Herald added subscribers: melifaro, imp. · View Herald TranscriptMay 21 2021, 3:14 PM

kp requested review of this revision.May 21 2021, 3:14 PM

kp added a parent revision: D30381: dummynet: Fix schedlist and aqmlist locking.

Harbormaster completed remote builds in B39338: Diff 89599.May 21 2021, 3:15 PM

kp added a reviewer: pfsense.May 26 2021, 6:12 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 3 2021, 3:20 PM

Closed by commit rG1b2dbe37fa32: dummynet: free(NULL, M_DUMMYNET); is safe (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG1b2dbe37fa32: dummynet: free(NULL, M_DUMMYNET); is safe.

kp added a commit: rG719f6456fbde: dummynet: free(NULL, M_DUMMYNET); is safe.Jun 17 2021, 2:56 PM

Herald added a subscriber: donner. · View Herald TranscriptJun 17 2021, 2:56 PM

kp added a commit: rG932531232a9d: dummynet: free(NULL, M_DUMMYNET); is safe.Jun 17 2021, 2:56 PM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

ip_dummynet.c

46 lines

Diff 89599

View Options

sys/netpfil/ipfw/ip_dummynet.c

dummynet: free(NULL, M_DUMMYNET); is safeClosedPublicActions