Page MenuHomeFreeBSD

dummynet: Fix schedlist and aqmlist locking
ClosedPublic

Authored by kp on May 21 2021, 3:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 4, 6:24 AM
Unknown Object (File)
Mon, Mar 30, 12:41 PM
Unknown Object (File)
Mon, Mar 30, 2:29 AM
Unknown Object (File)
Thu, Mar 26, 12:58 AM
Unknown Object (File)
Fri, Mar 20, 7:55 AM
Unknown Object (File)
Thu, Mar 19, 7:07 PM
Unknown Object (File)
Thu, Mar 19, 12:26 PM
Unknown Object (File)
Thu, Mar 19, 3:41 AM

Details

Summary

These are global (i.e. shared across vnets) structures, so we need
global lock to protect them. However, we look up entries in these lists
(find_aqm_type(), find_sched_type()) and return them. We must ensure
that the returned structures cannot go away while we are using them.

Resolve this by using NET_EPOCH(). The structures can be safely accessed
under it, and we postpone their cleanup until we're sure they're no
longer used.

MFC after: 2 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp requested review of this revision.May 21 2021, 3:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 3 2021, 3:20 PM
This revision was automatically updated to reflect the committed changes.