Page MenuHomeFreeBSD

dummynet: Fix schedlist and aqmlist locking
ClosedPublic

Authored by kp on May 21 2021, 3:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 2, 2:40 AM
Unknown Object (File)
Mon, Dec 1, 7:00 AM
Unknown Object (File)
Mon, Dec 1, 6:59 AM
Unknown Object (File)
Mon, Dec 1, 6:54 AM
Unknown Object (File)
Wed, Nov 19, 9:41 AM
Unknown Object (File)
Wed, Nov 19, 7:41 AM
Unknown Object (File)
Wed, Nov 19, 6:57 AM
Unknown Object (File)
Tue, Nov 18, 5:14 AM

Details

Summary

These are global (i.e. shared across vnets) structures, so we need
global lock to protect them. However, we look up entries in these lists
(find_aqm_type(), find_sched_type()) and return them. We must ensure
that the returned structures cannot go away while we are using them.

Resolve this by using NET_EPOCH(). The structures can be safely accessed
under it, and we postpone their cleanup until we're sure they're no
longer used.

MFC after: 2 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp requested review of this revision.May 21 2021, 3:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 3 2021, 3:20 PM
This revision was automatically updated to reflect the committed changes.