Page MenuHomeFreeBSD

dummynet: Fix schedlist and aqmlist locking

Authored by kp on May 21 2021, 3:14 PM.



These are global (i.e. shared across vnets) structures, so we need
global lock to protect them. However, we look up entries in these lists
(find_aqm_type(), find_sched_type()) and return them. We must ensure
that the returned structures cannot go away while we are using them.

Resolve this by using NET_EPOCH(). The structures can be safely accessed
under it, and we postpone their cleanup until we're sure they're no
longer used.

MFC after: 2 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

rG FreeBSD src repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kp requested review of this revision.May 21 2021, 3:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 3 2021, 3:20 PM
This revision was automatically updated to reflect the committed changes.