Page MenuHomeFreeBSD

arm64/rk_pcie_phy: handle assigned-clock*
ClosedPublic

Authored by bz on May 20 2021, 5:06 PM.

Details

Summary

Nanopi4 based SoCs (NanoPC-T4, NanoPi M4*, and NanoPi Neo4) have
assigned-clock* in the pcie_phy node. Handle them but do not fail
in case clk_set_assigned() returns an error (as it would for
other SoCs).

Reviewed by: ..
MFC After: 2 weeks
Differential Revision: ..

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bz requested review of this revision.May 20 2021, 5:06 PM

Anyone? Otherwise I'll commit this within the next week.

sys/arm64/rockchip/rk_pcie_phy.c
300

We should fail if rv != ENOENT
Otherwise just be silent is enough.

In case off error not being ENOENT log and fail as suggested by @manu.

bz marked an inline comment as done.Jun 5 2021, 4:12 PM
bz added inline comments.
sys/arm64/rockchip/rk_pcie_phy.c
300

Like this?

This revision is now accepted and ready to land.Jun 5 2021, 4:17 PM
This revision was automatically updated to reflect the committed changes.
bz marked an inline comment as done.