Page MenuHomeFreeBSD
Differential D30363

arm64/rk_pcie_phy: handle assigned-clock*
ClosedPublic
Actions

Authored by bz on May 20 2021, 5:06 PM.
Tags
None
Referenced Files
F171309953: D30363.id90456.diff
Thu, Sep 10, 7:52 AM
F171282714: D30363.id89545.diff
Thu, Sep 10, 3:08 AM
Unknown Object (File)
Tue, Sep 8, 11:02 PM
Unknown Object (File)
Sun, Sep 6, 1:32 PM
Unknown Object (File)
Sun, Sep 6, 12:02 AM
Unknown Object (File)
Sat, Sep 5, 9:58 PM
Unknown Object (File)
Sat, Sep 5, 9:46 PM
Unknown Object (File)
Sat, Sep 5, 3:42 PM
View All Files
Subscribers
andrew
emaste
imp
arm64

Details

Reviewers
mmel
manu
Commits
rG57af163c8e7e: arm64/rk_pcie_phy: handle assigned-clock*
Summary

Nanopi4 based SoCs (NanoPC-T4, NanoPi M4*, and NanoPi Neo4) have
assigned-clock* in the pcie_phy node. Handle them but do not fail
in case clk_set_assigned() returns an error (as it would for
other SoCs).

Reviewed by: ..
MFC After: 2 weeks
Differential Revision: ..

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz created this revision.May 20 2021, 5:06 PM
Herald added a reviewer: manu. · View Herald TranscriptMay 20 2021, 5:06 PM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
bz requested review of this revision.May 20 2021, 5:06 PM
Harbormaster completed remote builds in B39315: Diff 89545.May 20 2021, 5:06 PM
bz added a comment.Jun 5 2021, 3:48 PM

Anyone? Otherwise I'll commit this within the next week.

manu added inline comments.Jun 5 2021, 4:02 PM
sys/arm64/rockchip/rk_pcie_phy.c
301

We should fail if rv != ENOENT
Otherwise just be silent is enough.

bz updated this revision to Diff 90456.Jun 5 2021, 4:12 PM

In case off error not being ENOENT log and fail as suggested by @manu.

Harbormaster completed remote builds in B39727: Diff 90456.Jun 5 2021, 4:12 PM
bz marked an inline comment as done.Jun 5 2021, 4:12 PM
bz added inline comments.
sys/arm64/rockchip/rk_pcie_phy.c
301

Like this?

manu accepted this revision.Jun 5 2021, 4:17 PM

Yup, thanks.

This revision is now accepted and ready to land.Jun 5 2021, 4:17 PM
Closed by commit rG57af163c8e7e: arm64/rk_pcie_phy: handle assigned-clock* (authored by bz). · Explain WhyJun 5 2021, 4:34 PM
This revision was automatically updated to reflect the committed changes.
bz marked an inline comment as done.
bz added a commit: rG57af163c8e7e: arm64/rk_pcie_phy: handle assigned-clock*.

Revision Contents
Changeset List

PathSize
sys/
arm64/
rockchip/
7 lines

Diff 90457

View Options

sys/arm64/rockchip/rk_pcie_phy.c

Loading...