Page MenuHomeFreeBSD

PCI hot-plug: use dedicated taskqueue for device attach / detach
ClosedPublic

Authored by avg on May 6 2021, 5:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 6, 4:06 PM
Unknown Object (File)
Mon, Apr 6, 3:51 PM
Unknown Object (File)
Sun, Apr 5, 3:09 PM
Unknown Object (File)
Fri, Mar 27, 4:48 PM
Unknown Object (File)
Thu, Mar 26, 5:13 PM
Unknown Object (File)
Thu, Mar 26, 6:33 AM
Unknown Object (File)
Wed, Mar 25, 1:19 PM
Unknown Object (File)
Mon, Mar 16, 3:14 PM
Subscribers

Details

Summary

Attaching and detaching devices can be heavy-weight and detaching can
sleep waiting for events. For that reason using the system-wide
single-threaded taskqueue_thread is not really appropriate.
There is even a possibility for a deadlock if taskqueue_thread is used
for detaching.

In fact, there is an easy to reproduce deadlock involving nvme, pass
and a sudden removal of an NVMe device.
A pass peripheral would not release a reference on an nvme sim until
pass_shutdown_kqueue() is executed via taskqueue_thread. But the
taskqueue's thread is blocked in nvme_detach() -> ... -> cam_sim_free()
because of the outstanding reference.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable