Page MenuHomeFreeBSD

ixgbe: Clean up ix_txrx
ClosedPublic

Authored by kbowling on May 1 2021, 11:43 PM.

Details

Summary

The intention here is to reduce differences with D30072. The main functional change is logical simplification in ixgbe_rx_checksum.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Same comments regarding __predict() as in the e1000 review.

sys/dev/ixgbe/ix_txrx.c
438

I thought that intel shipped this as part of a backport to 11.x? I assume removing this will cause them unneeded pain,

kbowling added inline comments.
sys/dev/ixgbe/ix_txrx.c
438

It's possible, however this would have been some point in 11-CURRENT. Removing the ifdef should be safe for 11-RELEASE et al https://cgit.freebsd.org/src/commit/sys/sys/param.h?h=stable/11&id=10204535afded7f13a48badf29bcc1a33dc3c132

kbowling marked an inline comment as done.

Thanks for catching those mistakes. Can you take a look, I'm happy with this at the moment.

This revision is now accepted and ready to land.May 10 2021, 3:03 PM