Page MenuHomeFreeBSD
Differential D30074

ixgbe: Clean up ix_txrx
ClosedPublic
Actions

Authored by kbowling on May 1 2021, 11:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 19, 6:54 PM
Unknown Object (File)
Tue, May 19, 7:07 AM
Unknown Object (File)
Mon, May 18, 11:18 PM
Unknown Object (File)
Mon, May 18, 6:13 PM
Unknown Object (File)
Mon, May 18, 8:17 AM
Unknown Object (File)
Sun, May 17, 9:39 PM
Unknown Object (File)
Sun, May 17, 8:30 PM
Unknown Object (File)
Sun, May 17, 7:22 PM
View All Files
Subscribers
ae

Details

Reviewers
erj
kgalazka
gallatin
grehan
Group Reviewers
Intel Networking
Commits
rGfd350dd7ff94: ixgbe: Clean up ix_txrx
rGfe6803c18e81: ixgbe: Clean up ix_txrx
rG51e46835e10a: ixgbe: Clean up ix_txrx
Summary

The intention here is to reduce differences with D30072. The main functional change is logical simplification in ixgbe_rx_checksum.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kbowling created this revision.May 1 2021, 11:43 PM
Herald added a subscriber: ae. · View Herald TranscriptMay 1 2021, 11:43 PM
kbowling requested review of this revision.May 1 2021, 11:43 PM
gallatin added a comment.May 2 2021, 3:52 PM

Same comments regarding __predict() as in the e1000 review.

sys/dev/ixgbe/ix_txrx.c
438

I thought that intel shipped this as part of a backport to 11.x? I assume removing this will cause them unneeded pain,

kbowling marked an inline comment as done.May 3 2021, 9:53 PM
kbowling added inline comments.
sys/dev/ixgbe/ix_txrx.c
438

It's possible, however this would have been some point in 11-CURRENT. Removing the ifdef should be safe for 11-RELEASE et al https://cgit.freebsd.org/src/commit/sys/sys/param.h?h=stable/11&id=10204535afded7f13a48badf29bcc1a33dc3c132

kbowling updated this revision to Diff 88929.May 10 2021, 3:46 AM
kbowling marked an inline comment as done.

Thanks for catching those mistakes. Can you take a look, I'm happy with this at the moment.

gallatin accepted this revision.May 10 2021, 3:03 PM
This revision is now accepted and ready to land.May 10 2021, 3:03 PM
Closed by commit rG51e46835e10a: ixgbe: Clean up ix_txrx (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhyJul 18 2021, 6:26 AM
This revision was automatically updated to reflect the committed changes.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG51e46835e10a: ixgbe: Clean up ix_txrx.
Kevin Bowling <kbowling@FreeBSD.org> mentioned this in rG9fd0cda92d33: e1000: Add missing branch prediction.Jul 20 2021, 7:23 AM
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGfe6803c18e81: ixgbe: Clean up ix_txrx.Jul 30 2021, 12:31 AM
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGfd350dd7ff94: ixgbe: Clean up ix_txrx.Jul 30 2021, 12:42 AM
Kevin Bowling <kbowling@FreeBSD.org> mentioned this in rGb91bb9b07f75: e1000: Add missing branch prediction.Aug 3 2021, 2:05 AM
Kevin Bowling <kbowling@FreeBSD.org> mentioned this in rGa1b9408f97d1: e1000: Add missing branch prediction.Aug 3 2021, 2:12 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
ixgbe/
87 lines

Diff 92392

View Options

sys/dev/ixgbe/ix_txrx.c

Loading...