Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 38874 Build 35763: arc lint + arc unit
Event Timeline
sys/compat/linuxkpi/common/include/linux/spinlock.h | ||
---|---|---|
169 | The {} isn't needed for this block since you have only one line. |
Comment Actions
Via email, @kbowling says that in style(9) "Values in return statements should be enclosed in parentheses."
Comment Actions
Note that this isn't a hard rule as some parts of the tree are less conformant than others. But in the previous review the parens were mentioned and this is what was meant.