Page MenuHomeFreeBSD

linuxkpi: Conform to style(9) in atomic_dec_and_lock_irqsave()
AbandonedPublic

Authored by nc on Apr 26 2021, 5:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 30 2023, 3:26 AM
Unknown Object (File)
Apr 8 2023, 10:40 AM
Unknown Object (File)
Mar 22 2023, 8:08 AM

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38874
Build 35763: arc lint + arc unit

Event Timeline

nc requested review of this revision.Apr 26 2021, 5:15 PM
sys/compat/linuxkpi/common/include/linux/spinlock.h
169

The {} isn't needed for this block since you have only one line.

Via email, @kbowling says that in style(9) "Values in return statements should be enclosed in parentheses."

In D29998#673044, @nc wrote:

Via email, @kbowling says that in style(9) "Values in return statements should be enclosed in parentheses."

Note that this isn't a hard rule as some parts of the tree are less conformant than others. But in the previous review the parens were mentioned and this is what was meant.