Page MenuHomeFreeBSD

stats.7: Add dwatch(1) to the list
ClosedPublic

Authored by fernape on Apr 22 2021, 2:00 PM.

Details

Summary

PR: 255303

Test Plan
  • mandoc -Tlint clean
  • igor clean
  • aspell happy
  • man ./stats.7 renders the page properly

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Just a note, ctlstat seems to be missing from the SEE ALSO section. That could be another commit.

Also, could you MFC that? To 13.0 at least (I am not sure if other branches have stats(7)).

This revision is now accepted and ready to land.Apr 22 2021, 2:36 PM
In D29924#671479, @0mp wrote:

Just a note, ctlstat seems to be missing from the SEE ALSO section. That could be another commit.

OK, I'll do it in a separate commit.

Also, could you MFC that? To 13.0 at least (I am not sure if other branches have stats(7)).

Sure. 12.2 has stats(7) too. But maybe MFC to 13 would be enough?

I'd MFC to both 12 and 13 then. There's always a chance someone's going to benefit from the doc changes on those stable branches.

In D29924#671479, @0mp wrote:

Just a note, ctlstat seems to be missing from the SEE ALSO section. That could be another commit.

OK, I'll do it in a separate commit.

Also, could you MFC that? To 13.0 at least (I am not sure if other branches have stats(7)).

Sure. 12.2 has stats(7) too. But maybe MFC to 13 would be enough?

I would think that this is wrong. The stats(7) framework is only in stable/13 and main. So the MFC should only be done for stable/13.

In D29924#671628, @gbe wrote:
In D29924#671479, @0mp wrote:

Just a note, ctlstat seems to be missing from the SEE ALSO section. That could be another commit.

OK, I'll do it in a separate commit.

Also, could you MFC that? To 13.0 at least (I am not sure if other branches have stats(7)).

Sure. 12.2 has stats(7) too. But maybe MFC to 13 would be enough?

I would think that this is wrong. The stats(7) framework is only in stable/13 and main. So the MFC should only be done for stable/13.

HUmmm... One of my PCs runs in 12.2 and has at least the man page:

fernape@beastie:/data/fernape_data/FreeBSD-repos/src$ uname -a 
FreeBSD beastie 12.2-RELEASE-p6 FreeBSD 12.2-RELEASE-p6 GENERIC  amd64
fernape@beastie:/data/fernape_data/FreeBSD-repos/src$ man -w stats
/usr/share/man/man7/stats.7.gz

I could also do the merge to stable/12 (I had to resolve a conflict with the .Dd line, in stable/13 it was fine).

In D29924#671628, @gbe wrote:
In D29924#671479, @0mp wrote:

Just a note, ctlstat seems to be missing from the SEE ALSO section. That could be another commit.

OK, I'll do it in a separate commit.

Also, could you MFC that? To 13.0 at least (I am not sure if other branches have stats(7)).

Sure. 12.2 has stats(7) too. But maybe MFC to 13 would be enough?

I would think that this is wrong. The stats(7) framework is only in stable/13 and main. So the MFC should only be done for stable/13.

HUmmm... One of my PCs runs in 12.2 and has at least the man page:

fernape@beastie:/data/fernape_data/FreeBSD-repos/src$ uname -a 
FreeBSD beastie 12.2-RELEASE-p6 FreeBSD 12.2-RELEASE-p6 GENERIC  amd64
fernape@beastie:/data/fernape_data/FreeBSD-repos/src$ man -w stats
/usr/share/man/man7/stats.7.gz

I could also do the merge to stable/12 (I had to resolve a conflict with the .Dd line, in stable/13 it was fine).

OK, no, it was definitely not fine. I forgot to fix the conflict at the end of the file. I'm so sorry about that.
How to proceed now?

Worth noting also that immediate MFC in base is a little unusual- typically there's a three day minimum soak time, and it should be denoted with a 'MFC after:' tag at the bottom of the commit.

Worth noting also that immediate MFC in base is a little unusual- typically there's a three day minimum soak time, and it should be denoted with a 'MFC after:' tag at the bottom of the commit.

Noted. I did not know about the convention. git log showed some MFC after tags, but since its purpose is a remainder, I did not interpreted it as mandatory.