iflib: make a required kernel component for drivers using it
AbandonedPublic
Actions

Authored by imp on Apr 19 2021, 9:21 PM.

Details

Reviewers

emaste
kevans
manu
andrew

Summary

iflib-using drivers require iflib is included in any kernels they are
part of. Note this requirement on the first file for each of the
affected drivers. Bump all the Makefiles since this construct is in
conf/sys/files and thus they all require config version 600019 to work
right.

MFC After: 1 week
Sponsored by: Netflix

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38701
Build 35590: arc lint + arc unit

Event Timeline

imp created this revision.Apr 19 2021, 9:21 PM

Herald added subscribers: emaste, andrew. · View Herald TranscriptApr 19 2021, 9:21 PM

imp requested review of this revision.Apr 19 2021, 9:21 PM

Harbormaster completed remote builds in B38701: Diff 87751.Apr 19 2021, 9:21 PM

imp added reviewers: emaste, kevans, manu, andrew.Apr 19 2021, 9:22 PM

imp added parent revisions: D29848: config: create a 'requires' keyword for files file processing, D29847: config: style for '\0' and NULL.

manu mentioned this in D29848: config: create a 'requires' keyword for files file processing.Apr 20 2021, 7:45 AM

kbowling added a subscriber: kbowling.Apr 20 2021, 9:20 PM

kbowling added inline comments.Apr 20 2021, 9:26 PM

sys/conf/files
1398	does the presense of iflib in the list here matter or do we need requires "iflib" \?
2305	requires "iflib" \
2307	requires "iflib" \
2310	can this move up to "if_ix.c"?