ixgbe: Clean up ixgbe_if_multi_set
ClosedPublic
Actions

Authored by kbowling on Apr 19 2021, 2:26 AM.

Details

Reviewers

markj
erj

Group Reviewers

Intel Networking

Commits

rGd88c3f9f0f48: ixgbe: Clean up unneeded set in ixgbe_if_multi_set
rG1567ceeb09c4: ixgbe: Clean up unneeded set in ixgbe_if_multi_set
rGdeecaa144526: ixgbe: Clean up unneeded set in ixgbe_if_multi_set

Summary

@markj's keen eye caught this in D29789, we don't need to set the bits here since the if/else if/else statements fully cover setting these bit pairs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kbowling created this revision.Apr 19 2021, 2:26 AM

Herald added a subscriber: ae. · View Herald TranscriptApr 19 2021, 2:26 AM

kbowling requested review of this revision.Apr 19 2021, 2:26 AM

kbowling edited the summary of this revision. (Show Details)

markj accepted this revision.Apr 19 2021, 1:00 PM

This revision is now accepted and ready to land.Apr 19 2021, 1:00 PM

erj accepted this revision.Apr 19 2021, 6:59 PM

Closed by commit rGdeecaa144526: ixgbe: Clean up unneeded set in ixgbe_if_multi_set (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhyApr 19 2021, 7:38 PM

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGdeecaa144526: ixgbe: Clean up unneeded set in ixgbe_if_multi_set.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG1567ceeb09c4: ixgbe: Clean up unneeded set in ixgbe_if_multi_set.May 28 2021, 5:29 AM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGd88c3f9f0f48: ixgbe: Clean up unneeded set in ixgbe_if_multi_set.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ixgbe/

if_ix.c

2 lines

Diff 87741

View Options

ixgbe: Clean up ixgbe_if_multi_setClosedPublicActions