Page MenuHomeFreeBSD
Differential D29814

bsd.prog.mk: Remove redundant check of the DEBUG_FLAGS
AbandonedPublic
Actions

Authored by 0mp on Apr 17 2021, 9:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 13, 5:37 PM
Unknown Object (File)
Sat, Jul 4, 10:06 AM
Unknown Object (File)
Sat, Jul 4, 2:56 AM
Unknown Object (File)
Thu, Jul 2, 5:38 AM
Unknown Object (File)
Tue, Jun 30, 12:43 AM
Unknown Object (File)
Sun, Jun 28, 9:35 AM
Unknown Object (File)
Sat, Jun 27, 7:40 AM
Unknown Object (File)
Thu, Jun 25, 3:54 AM
View All 95 Files
Subscribers
bdrewery
emaste
imp
yuripv

Details

Reviewers
jrtc27
emaste
arichardson
Group Reviewers
Contributor Reviews (src)
Summary

We already check if DEBUG_FLAGS is defined earlier in the same file, so
there is no need to check it again.

PR: 205036

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38657
Build 35546: arc lint + arc unit

Event Timeline

0mp created this revision.Apr 17 2021, 9:05 PM
Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptApr 17 2021, 9:05 PM
0mp requested review of this revision.Apr 17 2021, 9:05 PM
Harbormaster completed remote builds in B38657: Diff 87634.Apr 17 2021, 9:06 PM
yuripv added a subscriber: yuripv.Apr 17 2021, 10:41 PM
yuripv added inline comments.
share/mk/bsd.prog.mk
96

you seem to have lost one .endif

yuripv added inline comments.Apr 17 2021, 10:42 PM
share/mk/bsd.prog.mk
96

or no, you didn't, sorry.

0mp added a reviewer: Contributor Reviews (src).Apr 18 2021, 12:29 PM
0mp marked 2 inline comments as done.
0mp added reviewers: jrtc27, emaste, arichardson.Jul 8 2022, 7:41 PM

Change reviewers to the committers who last touched that file.

0mp abandoned this revision.Dec 13 2022, 2:34 PM

I don't think it is necessary to commit this style patch. The current version is readable. At the same time, the proposed change introduces a potentially confusing else statement, which has to be clarified with a comment.

Revision Contents
Changeset List

PathSize
share/
mk/
6 lines

Diff 87634

View Options

share/mk/bsd.prog.mk

Loading...