Page MenuHomeFreeBSD

bsd.prog.mk: Remove redundant check of the DEBUG_FLAGS
AbandonedPublic

Authored by 0mp on Apr 17 2021, 9:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 24 2023, 7:25 PM
Unknown Object (File)
Dec 23 2023, 2:13 AM
Unknown Object (File)
Nov 26 2023, 3:14 AM
Unknown Object (File)
Nov 25 2023, 5:33 PM
Unknown Object (File)
Nov 25 2023, 7:00 AM
Unknown Object (File)
Nov 23 2023, 11:16 AM
Unknown Object (File)
Nov 23 2023, 9:58 AM
Unknown Object (File)
Nov 23 2023, 5:29 AM

Details

Summary

We already check if DEBUG_FLAGS is defined earlier in the same file, so
there is no need to check it again.

PR: 205036

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38657
Build 35546: arc lint + arc unit

Event Timeline

0mp requested review of this revision.Apr 17 2021, 9:05 PM
yuripv added inline comments.
share/mk/bsd.prog.mk
96

you seem to have lost one .endif

share/mk/bsd.prog.mk
96

or no, you didn't, sorry.

0mp marked 2 inline comments as done.

Change reviewers to the committers who last touched that file.

I don't think it is necessary to commit this style patch. The current version is readable. At the same time, the proposed change introduces a potentially confusing else statement, which has to be clarified with a comment.