ipfw: do not use sleepable malloc in callout context.

[ae]

Summary

Use malloc(M_NOWAIT) when hash growing is called from callout.

PR: 255041

[ae]

• Fix copy/paste bug.

[kevans]

Thanks!

[ish_amail.plala.or.jp]

Thank you for this patch.
I'm applied this patch to 3a248c844 and it works fine.

[freebsd_igalic.co]

sys/netpfil/ipfw/ip_fw_dynamic.c

3224

why is it okay to wait here

[ae]

sys/netpfil/ipfw/ip_fw_dynamic.c

3224

It is initialization code, it is called from userland when you are doing kldload, user can wait.

sys/netpfil/ipfw/ip_fw_dynamic.c

 #define UMA_ALIGN       __aligned(UMA_SUPER_ALIGN)
 
 /*
  * The uma_bucket structure is used to queue and manage buckets divorced
  * from per-cpu caches.  They are loaded into uma_cache_bucket structures
  * for use.
  */
 struct uma_bucket {
-        TAILQ_ENTRY(uma_bucket)        ub_link;        /* Link into the zone */
+        STAILQ_ENTRY(uma_bucket)        ub_link; /* Link into the zone */
         int16_t         ub_cnt;                 /* Count of items in bucket. */
         int16_t         ub_entries;             /* Max items. */
         smr_seq_t       ub_seq;                 /* SMR sequence number. */
         void            *ub_bucket[];           /* actual allocation storage */
 };
 
 typedef struct uma_bucket * uma_bucket_t;
 

 {
         uintptr_t data;
 
         data = (uintptr_t)slab_data(slab, keg);
         return (((uintptr_t)item - data) / keg->uk_rsize);
 }
 #endif /* _KERNEL */
 
-TAILQ_HEAD(uma_bucketlist, uma_bucket);
+STAILQ_HEAD(uma_bucketlist, uma_bucket);
 
 struct uma_zone_domain {
         struct uma_bucketlist uzd_buckets; /* full buckets */
         uma_bucket_t    uzd_cross;      /* Fills from cross buckets. */
         long            uzd_nitems;     /* total item count */
         long            uzd_imax;       /* maximum item count this period */
         long            uzd_imin;       /* minimum item count this period */
         long            uzd_wss;        /* working set size estimate */