Page MenuHomeFreeBSD

ipfw: do not use sleepable malloc in callout context.
ClosedPublic

Authored by ae on Apr 15 2021, 12:35 PM.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ae published this revision for review.Apr 15 2021, 12:37 PM
ae edited the summary of this revision. (Show Details)
ae added reviewers: network, melifaro, kevans.
This revision is now accepted and ready to land.Apr 15 2021, 1:08 PM

Thank you for this patch.
I'm applied this patch to 3a248c844 and it works fine.

me_igalic.co added inline comments.
sys/netpfil/ipfw/ip_fw_dynamic.c
3224

why is it okay to wait here

sys/netpfil/ipfw/ip_fw_dynamic.c
3224

It is initialization code, it is called from userland when you are doing kldload, user can wait.