Page MenuHomeFreeBSD

lib/msun: Exclude ignored-pragmas from -Werror
ClosedPublic

Authored by arichardson on Apr 13 2021, 11:59 AM.

Details

Summary

This avoids build failures due to the clang 12 warning:

'#pragma FENV_ACCESS' is not supported on this target - ignored
Test Plan

compiles with clang12

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Is this now on e.g. PowerPC etc? Or also on x86? But in any case, LGTM.

This revision is now accepted and ready to land.Apr 13 2021, 1:34 PM

I saw this building CheriBSD, and I think it affected almost all architectures.

Ah, I thought maybe now that the StrictFP stuff is operational we might finally get some #pragma FENV_ACCESS support, but it's probably a whole other can of worms...

Looks like the warning is not triggered for x86, only other architectures. That indicates that the pragmas might actually be implemented now.
Should I restrict the -Wno-error to non-x86?