pci_dw.c: Trim ATU windows bigger than 4GB
ClosedPublic
Actions

Authored by kd on Apr 7 2021, 11:19 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 1, 7:20 AM

	Unknown Object (File)
	Jan 14 2024, 8:16 PM

	Unknown Object (File)
	Dec 19 2023, 2:58 AM

	Unknown Object (File)
	Dec 12 2023, 5:54 AM

	Unknown Object (File)
	Nov 29 2023, 1:52 AM

	Unknown Object (File)
	Sep 28 2023, 12:22 AM

	Unknown Object (File)
	Sep 28 2023, 12:19 AM

	Unknown Object (File)
	Sep 28 2023, 12:18 AM

View All 25 Files

Subscribers

imp

Details

Reviewers

mmel
mw
wma

Commits

rG8f2e39b9d3ec: pci_dw: Trim ATU windows bigger than 4GB
rG215db69fbcb0: pci_dw: Trim ATU windows bigger than 4GB
rG243000b19f8b: pci_dw: Trim ATU windows bigger than 4GB

Summary

The size of the ATU MEM/IO windows is implicitly casted to uint32_t.
Because of that some window sizes were silently demoted to 0 and ignored.
Check the size if its too large, trim it to 4GB and print a warning message.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kd requested review of this revision.Apr 7 2021, 11:19 AM

kd created this revision.

mw accepted this revision.Apr 7 2021, 1:55 PM

This revision is now accepted and ready to land.Apr 7 2021, 1:55 PM

Closed by commit rG243000b19f8b: pci_dw: Trim ATU windows bigger than 4GB (authored by wma). · Explain WhyApr 9 2021, 7:40 AM

This revision was automatically updated to reflect the committed changes.

wma added a commit: rG243000b19f8b: pci_dw: Trim ATU windows bigger than 4GB.

jrtc27 added a commit: rG215db69fbcb0: pci_dw: Trim ATU windows bigger than 4GB.Sep 7 2021, 12:10 PM

mw added a commit: rG8f2e39b9d3ec: pci_dw: Trim ATU windows bigger than 4GB.Oct 14 2021, 4:20 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 14 2021, 4:20 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

pci/

pci_dw.c

12 lines

Diff 86956

View Options

pci_dw.c: Trim ATU windows bigger than 4GBClosedPublicActions