Page MenuHomeFreeBSD
Differential D2960

on i386 USRSTACK points one page below the VM_MAXUSER_ADDRESS
AbandonedPublic
Actions

Authored by op on Jun 30 2015, 3:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 4 2024, 4:26 PM
Unknown Object (File)
Feb 3 2024, 2:45 AM
Unknown Object (File)
Jan 4 2024, 9:58 PM
Unknown Object (File)
Dec 20 2023, 3:33 AM
Unknown Object (File)
Nov 23 2023, 7:16 PM
Unknown Object (File)
Nov 14 2023, 9:39 PM
Unknown Object (File)
Nov 10 2023, 1:17 AM
Unknown Object (File)
Nov 5 2023, 7:57 AM
View All 64 Files
Subscribers
imp

Details

Reviewers
kib
jhb
gnn
rwatson

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

op updated this revision to Diff 6592.Jun 30 2015, 3:53 PM
op retitled this revision from to on i386 USRSTACK points one page below the VM_MAXUSER_ADDRESS.
op updated this object.
op edited the test plan for this revision. (Show Details)
op added reviewers: kib, jhb, rwatson.
op set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a reviewer: gnn. · View Herald TranscriptJun 30 2015, 3:53 PM
Herald added a subscriber: imp. · View Herald Transcript
kib edited edge metadata.Jun 30 2015, 6:04 PM

This looks fine. Would you move IN_KERNEL() macro into some common location and then just #define PMC_IN_KERNEL(va) IN_KERNEL(va) ?

op updated this revision to Diff 6609.Jun 30 2015, 10:15 PM
op edited edge metadata.
op removed rS FreeBSD src repository - subversion as the repository for this revision.

I have found this error in one more place. Added the fix to the updated patch.

op added a comment.Jun 30 2015, 10:17 PM

The potential common place could be the pmap.h or something else?
I have found this macro in sys/$arch/stack.h file, but I not really like the header pollution across independent header files.

op updated this revision to Diff 6613.Jul 1 2015, 12:50 AM

Typo fix.

kib added a comment.Jul 1 2015, 6:20 PM

I put the commit candidate patch at https://reviews.freebsd.org/D2971 .

op abandoned this revision.Sep 21 2015, 10:51 AM

This was superseded with D2971, so close them.

Revision Contents
Changeset List

PathSize
sys/
cddl/
dev/
dtrace/
i386/
2 lines
i386/
include/
2 lines
2 lines

Diff 6613

View Options

sys/cddl/dev/dtrace/i386/dtrace_isa.c

Loading...
View Options

sys/i386/include/pmc_mdep.h

Loading...
View Options

sys/i386/include/stack.h

Loading...