Page MenuHomeFreeBSD

cxgbe(4): Always use the per-VI callout to read interface stats.
ClosedPublic

Authored by np on Apr 1 2021, 8:43 AM.

Details

Summary

There is no change in the source of the stats (t4_get_port_stats or
t4_get_vi_stats) but the per-port callout is gone.

Sponsored by: Chelsio Communications

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

np requested review of this revision.Apr 1 2021, 8:43 AM
sys/dev/cxgbe/t4_main.c
6283

This seems a bit odd as it means you will drop/pickup this lock several times. Maybe make the acquire of this lock in vi_refresh_stats() conditional on IS_VF instead and move the assertion here?

np marked an inline comment as done.Apr 1 2021, 5:57 PM

Acquire reg_lock around read_vf_stat instead of in a loop in the function.

This revision is now accepted and ready to land.Apr 1 2021, 9:20 PM