Paths

Table of Contentst

Differential D29383

cxgbe: Make the TOE TLS stats per-queue instead of per-port.
ClosedPublic
Actions

Authored by jhb on Mar 22 2021, 10:44 PM.

Tags

None

Referenced Files

	F81637755: D29383.id86373.diff
	Fri, Apr 19, 8:04 AM

	Unknown Object (File)
	Thu, Mar 28, 11:25 PM

	Unknown Object (File)
	Jan 18 2024, 6:29 AM

	Unknown Object (File)
	Dec 23 2023, 3:08 AM

	Unknown Object (File)
	Dec 19 2023, 11:34 PM

	Unknown Object (File)
	Dec 12 2023, 7:43 AM

	Unknown Object (File)
	Dec 3 2023, 6:31 AM

	Unknown Object (File)
	Dec 1 2023, 11:06 PM

View All 24 Files

Subscribers

Details

Reviewers

Commits

rGfe496dc02a9a: cxgbe: Make the TOE TLS stats per-queue instead of per-port.

Summary

This avoids some atomics by using counter_u64 for TX and relying on
existing single-threading (single ithread per rxq) for RX.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37998
Build 34887: arc lint + arc unit

Event Timeline

jhb created this revision.Mar 22 2021, 10:44 PM

Herald added subscribers: ae, imp. · View Herald TranscriptMar 22 2021, 10:44 PM

jhb requested review of this revision.Mar 22 2021, 10:44 PM

jhb added a parent revision: D29382: cxgbe: Add a struct sge_ofld_txq type..

Harbormaster completed remote builds in B37998: Diff 86172.Mar 22 2021, 10:44 PM

jhb added inline comments.Mar 22 2021, 10:48 PM

sys/dev/cxgbe/t4_sge.c
1253	A question here is if we want to have `alloc_ofld_txq` and `free_ofld_txq` helper functions in t4_sge.c as we currently have for offload RX queues. If so, I would probably go back and do that in the previous commit that introduced `struct sge_ofld_txq`

Update for alloc/free_txq_ofld().

Harbormaster completed remote builds in B38029: Diff 86223.Mar 23 2021, 9:54 PM

np accepted this revision.Mar 26 2021, 9:46 PM

This revision is now accepted and ready to land.Mar 26 2021, 9:46 PM

Closed by commit rGfe496dc02a9a: cxgbe: Make the TOE TLS stats per-queue instead of per-port. (authored by jhb). · Explain WhyMar 26 2021, 10:20 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGfe496dc02a9a: cxgbe: Make the TOE TLS stats per-queue instead of per-port..

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

8 lines

17 lines

20 lines

tom/

12 lines

Diff 86172

sys/dev/cxgbe/adapter.h

Loading...

sys/dev/cxgbe/t4_main.c

Loading...

sys/dev/cxgbe/t4_sge.c

Loading...

sys/dev/cxgbe/tom/t4_tls.c

Loading...