Page MenuHomeFreeBSD

cxgbe: Add a struct sge_ofld_txq type.
ClosedPublic

Authored by jhb on Mon, Mar 22, 10:44 PM.

Details

Summary

This type mirrors struct sge_ofld_rxq and holds state for TCP offload
transmit queues. Currently it only holds a work queue but will
include additional state in future changes.

Sponsored by: Chelsio Communications

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Mon, Mar 22, 10:44 PM
  • Add alloc/free_ofld_txq() routines.

The offload tx queues are also used for RATELIMIT tx and we should either set cxgbe_rate_tag->eo_txq to ofld_txq->wrq in ethofld_transmit or change eo_txq to be a sge_ofld_txq.

np requested changes to this revision.Thu, Mar 25, 5:17 AM

There's also this in t4_main.c that needs to be updated to sizeof(struct sge_ofld_txq):

s->ofld_txq = malloc(s->nofldtxq * sizeof(struct sge_wrq),  M_CXGBE, M_ZERO | M_WAITOK);
This revision now requires changes to proceed.Thu, Mar 25, 5:17 AM
  • Fix with RATELIMIT and malloc size.
sys/dev/cxgbe/t4_main.c
1337

Using 'sizeof(*s->ofld_txq)' here instead of the type would perhaps have been more future proof.

sys/dev/cxgbe/t4_sge.c
6447

I changed the type of cst->eo_txq so that this line would still work (and it also seemed more natural for eo_txq to point to the actual txq rather than just the embedded wrq).

This revision is now accepted and ready to land.Thu, Mar 25, 10:37 PM

Let's land this if it's ready.

This revision was automatically updated to reflect the committed changes.