Page MenuHomeFreeBSD
Differential D29383

cxgbe: Make the TOE TLS stats per-queue instead of per-port.
ClosedPublic
Actions

Authored by jhb on Mar 22 2021, 10:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 20, 11:33 AM
Unknown Object (File)
Sat, Apr 11, 11:49 PM
Unknown Object (File)
Sat, Apr 11, 8:53 AM
Unknown Object (File)
Fri, Apr 10, 10:33 PM
Unknown Object (File)
Fri, Apr 10, 1:16 PM
Unknown Object (File)
Fri, Apr 10, 4:15 AM
Unknown Object (File)
Sun, Apr 5, 7:09 AM
Unknown Object (File)
Tue, Mar 31, 1:26 PM
View All Files
Subscribers
ae
imp

Details

Reviewers
np
Commits
rGfe496dc02a9a: cxgbe: Make the TOE TLS stats per-queue instead of per-port.
Summary

This avoids some atomics by using counter_u64 for TX and relying on
existing single-threading (single ithread per rxq) for RX.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Mar 22 2021, 10:44 PM
Herald added subscribers: ae, imp. · View Herald TranscriptMar 22 2021, 10:44 PM
jhb requested review of this revision.Mar 22 2021, 10:44 PM
jhb added a parent revision: D29382: cxgbe: Add a struct sge_ofld_txq type..
Harbormaster completed remote builds in B37998: Diff 86172.Mar 22 2021, 10:44 PM
jhb added inline comments.Mar 22 2021, 10:48 PM
sys/dev/cxgbe/t4_sge.c
1252

A question here is if we want to have alloc_ofld_txq and free_ofld_txq helper functions in t4_sge.c as we currently have for offload RX queues. If so, I would probably go back and do that in the previous commit that introduced struct sge_ofld_txq

jhb updated this revision to Diff 86223.Mar 23 2021, 9:53 PM
  • Update for alloc/free_txq_ofld().
Harbormaster completed remote builds in B38029: Diff 86223.Mar 23 2021, 9:54 PM
np accepted this revision.Mar 26 2021, 9:46 PM
This revision is now accepted and ready to land.Mar 26 2021, 9:46 PM
Closed by commit rGfe496dc02a9a: cxgbe: Make the TOE TLS stats per-queue instead of per-port. (authored by jhb). · Explain WhyMar 26 2021, 10:20 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGfe496dc02a9a: cxgbe: Make the TOE TLS stats per-queue instead of per-port..

Revision Contents
Changeset List

PathSize
sys/
dev/
cxgbe/
8 lines
17 lines
20 lines
tom/
12 lines

Diff 86373

View Options

sys/dev/cxgbe/adapter.h

Loading...
View Options

sys/dev/cxgbe/t4_main.c

Loading...
View Options

sys/dev/cxgbe/t4_sge.c

Loading...
View Options

sys/dev/cxgbe/tom/t4_tls.c

Loading...