pf: Remove redundant kif != NULL checks
ClosedPublic
Actions

Authored by kp on Mar 10 2021, 4:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 18, 1:12 PM

	Unknown Object (File)
	Jan 18 2024, 1:16 PM

	Unknown Object (File)
	Jan 16 2024, 3:05 AM

	Unknown Object (File)
	Jan 5 2024, 5:42 PM

	Unknown Object (File)
	Dec 20 2023, 2:56 AM

	Unknown Object (File)
	Dec 18 2023, 4:02 PM

	Unknown Object (File)
	Dec 14 2023, 10:42 PM

	Unknown Object (File)
	Sep 23 2023, 1:29 AM

Subscribers

Details

Reviewers

melifaro

Group Reviewers

network

Commits

rG28ed948ec1d7: pf: Remove redundant kif != NULL checks
rG2001c1a0d2c0: pf: Remove redundant kif != NULL checks
rG913e7dc3e0eb: pf: Remove redundant kif != NULL checks

Summary

pf_kkif_free() already checks for NULL, so we don't have to check before
we call it.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Mar 10 2021, 4:05 PM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptMar 10 2021, 4:05 PM

kp requested review of this revision.Mar 10 2021, 4:05 PM

Harbormaster completed remote builds in B37735: Diff 85492.Mar 10 2021, 4:05 PM

melifaro accepted this revision.Mar 10 2021, 8:56 PM

This revision is now accepted and ready to land.Mar 10 2021, 8:56 PM

Closed by commit rG913e7dc3e0eb: pf: Remove redundant kif != NULL checks (authored by kp). · Explain WhyMar 11 2021, 9:42 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG913e7dc3e0eb: pf: Remove redundant kif != NULL checks.

kp added a commit: rG2001c1a0d2c0: pf: Remove redundant kif != NULL checks.Mar 20 2021, 10:00 AM

kp added a commit: rG28ed948ec1d7: pf: Remove redundant kif != NULL checks.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_ioctl.c

9 lines

Diff 85562

View Options

pf: Remove redundant kif != NULL checksClosedPublicActions