Differential D29195

pf: Remove redundant kif != NULL checks
ClosedPublic
Actions

Authored by kp on Mar 10 2021, 4:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Aug 10, 8:53 PM

	Unknown Object (File)
	Sat, Aug 8, 5:15 PM

	Unknown Object (File)
	Fri, Aug 7, 5:59 PM

	Unknown Object (File)
	Thu, Aug 6, 2:38 AM

	Unknown Object (File)
	Wed, Jul 22, 11:42 PM

	Unknown Object (File)
	Tue, Jul 21, 2:14 AM

	Unknown Object (File)
	Jul 4 2026, 10:53 AM

	Unknown Object (File)
	Jul 3 2026, 4:25 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG28ed948ec1d7: pf: Remove redundant kif != NULL checks
rG2001c1a0d2c0: pf: Remove redundant kif != NULL checks
rG913e7dc3e0eb: pf: Remove redundant kif != NULL checks

Summary

pf_kkif_free() already checks for NULL, so we don't have to check before
we call it.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Mar 10 2021, 4:05 PM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptMar 10 2021, 4:05 PM

kp requested review of this revision.Mar 10 2021, 4:05 PM

Harbormaster completed remote builds in B37735: Diff 85492.Mar 10 2021, 4:05 PM

melifaro accepted this revision.Mar 10 2021, 8:56 PM

This revision is now accepted and ready to land.Mar 10 2021, 8:56 PM

Closed by commit rG913e7dc3e0eb: pf: Remove redundant kif != NULL checks (authored by kp). · Explain WhyMar 11 2021, 9:42 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG913e7dc3e0eb: pf: Remove redundant kif != NULL checks.

kp added a commit: rG2001c1a0d2c0: pf: Remove redundant kif != NULL checks.Mar 20 2021, 10:00 AM

kp added a commit: rG28ed948ec1d7: pf: Remove redundant kif != NULL checks.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

9 lines

Diff 85562

sys/netpfil/pf/pf_ioctl.c

Loading...