Differential D29088

remove a superfluous local var
ClosedPublic
Actions

Authored by rscheff on Mar 5 2021, 3:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 12 2025, 4:42 AM

	Unknown Object (File)
	Dec 1 2025, 5:09 PM

	Unknown Object (File)
	Nov 16 2025, 8:41 AM

	Unknown Object (File)
	Nov 13 2025, 2:30 AM

	Unknown Object (File)
	Nov 10 2025, 12:58 PM

	Unknown Object (File)
	Oct 28 2025, 11:45 PM

	Unknown Object (File)
	Oct 28 2025, 2:28 AM

	Unknown Object (File)
	Oct 25 2025, 3:42 PM

View All 77 Files

Subscribers

Details

Reviewers

tuexen
rrs
jtl

Group Reviewers

Commits

rG7ab9fef1be9d: tcp: remove a superfluous local var in tcp_sack_partialack()
rG9a13d9dceee2: tcp: remove a superfluous local var in tcp_sack_partialack()

Summary

While reviewing recently added SACK related code, a
superfluous local variable was found, which already
exists in the parent scope.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rscheff created this revision.Mar 5 2021, 3:45 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptMar 5 2021, 3:45 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Mar 5 2021, 3:45 PM

Harbormaster completed remote builds in B37608: Diff 85211.Mar 5 2021, 3:46 PM

tuexen accepted this revision.Mar 5 2021, 3:47 PM

This revision is now accepted and ready to land.Mar 5 2021, 3:47 PM

Closed by commit rG9a13d9dceee2: tcp: remove a superfluous local var in tcp_sack_partialack() (authored by rscheff). · Explain WhyMar 5 2021, 5:24 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rG9a13d9dceee2: tcp: remove a superfluous local var in tcp_sack_partialack().

rscheff added a commit: rG7ab9fef1be9d: tcp: remove a superfluous local var in tcp_sack_partialack().Mar 8 2021, 11:23 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

1 line

Diff 85226

sys/netinet/tcp_sack.c

Loading...