Differential D28943

arm64: update kdb_thrctx->pcb_lr with BKPT_SKIP
ClosedPublic
Actions

Authored by mhorne on Feb 26 2021, 5:44 PM.

Tags

None

Subscribers

Details

Reviewers

jhb
manu
markj
andrew

Commits

R10:bd0b7cbf5ac1: arm64: update kdb_thrctx->pcb_lr with BKPT_SKIP

Summary

This value should be kept in sync with updates to kdb_frame->tf_elr,
since it is queried by PC_REGS() in several places.

Diff Detail

Repository

R10 FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mhorne created this revision.Feb 26 2021, 5:44 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 26 2021, 5:44 PM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

mhorne requested review of this revision.Feb 26 2021, 5:44 PM

Harbormaster completed remote builds in B37412: Diff 84754.Feb 26 2021, 5:44 PM

mhorne added reviewers: markj, andrew.Feb 26 2021, 6:02 PM

Hmm, this does mimic what amd64 does.

This revision is now accepted and ready to land.Feb 26 2021, 7:35 PM

markj accepted this revision.Feb 27 2021, 4:49 PM

Closed by commit R10:bd0b7cbf5ac1: arm64: update kdb_thrctx->pcb_lr with BKPT_SKIP (authored by mhorne). · Explain WhyMar 1 2021, 2:08 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: R10:bd0b7cbf5ac1: arm64: update kdb_thrctx->pcb_lr with BKPT_SKIP.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

include/

5 lines

Diff 84898

sys/arm64/include/db_machdep.h

Loading...