Please fix distinfo of arcanist and test building all three ports.
(I'll install and test those versions @work to see if they are ok otherwise)
I assume this should be phacility-arcanist-20150623-...
===> License APACHE20 accepted by the user ===> php5-arcanist-20150623 depends on file: /usr/local/sbin/pkg - found => phacility-arcanist-20150623-b697a3b_GH0.tar.gz is not in /basejail/usr/ports/devel/arcanist/distinfo. => Either /basejail/usr/ports/devel/arcanist/distinfo is out of date, or => phacility-arcanist-20150623-b697a3b_GH0.tar.gz is spelled incorrectly. *** Error code 1
This works for me?
[10010 eax@fbsdvm .../ports/devel/arcanist !2!]%make makesum ===> License APACHE20 accepted by the user ===> php5-arcanist-20150623 depends on file: /usr/local/sbin/pkg - found ===> Fetching all distfiles required by php5-arcanist-20150623 for building
looks fine to me:
After fixing libphutil/distinfo this installed fine. I rolled it out at work yesterday and so far it seems to work ok.
I applied the raw patch (download raw diff) and that contained:
-SHA256 (phacility-arcanist-20150602-8c589f1_GH0.tar.gz) = f00c87d46654d4b5d333e031d35cf923b7f0168e5fc6a2440f7688ffd1d4e27c -SIZE (phacility-arcanist-20150602-8c589f1_GH0.tar.gz) = 458899 +SHA256 (phacility-arcanist-20150602-b697a3b_GH0.tar.gz) = f98715b9c4aaae44ff1ce2649ee3bd9819053669597251637a55d24a12530244 +SIZE (phacility-arcanist-20150602-b697a3b_GH0.tar.gz) = 460003 Index: devel/arcanist/pkg-plist
So either I missed an iteration or it's (ironically) a phabricator problem.
This is definitely broken, also in the latest iteration.
Unfortunately Phabricator is not good at indenting, is there anything we can do to fix this? Indentation should be ok here, like you said.
@mat this won't build as long as devel/libphutil/distinfo is broken (see my comment above). Accept Revision shouldn't have an "if it works" comment in it, but mean that some actual review happened (well, AFAIK).
Also note that this version won't include the workaround for curl 7.43 that broke arcanist.
Then, apply the patch and run make makesum, there fixed it for you.
Yes, please, make it work, it's been broken too long.
I'm more than happy to pass those ports on to you @mat or phabric-admin, please make sure you update and test devel/phabrictor though (as phabric-admin@ runs a heavily customized version of phabricator).
By the way, there are no bug reports in bugs.freebsd.org for any of the affected packages (devel/libphutil, devel/arcanist or ftp/curl, which is a big part of the problem).
To wrap this up (as there has been some confusion):
The problem with arcanist was caused by a problem in curl 7.43.0, a workaround to libphutil was released on June 24th (one day after this review was opened), the whole discussion of the problem can be found here: https://secure.phabricator.com/T8654
I opened PR 201147 that incorporates the patch to ftp/curl from upstream. In my opinion this would've been the correct way to fix this in the first place, instead of rushing to release a workaround version of libphutil and not fixing the issue for other uses of libcurl.