Page MenuHomeFreeBSD

Update manpage for AMD 10GbE driver
ClosedPublic

Authored by rajeshasp on Feb 17 2021, 4:21 AM.

Details

Summary
  1. Removed the description above removed sysctl "single_fl"
  2. Added the description for sysctl "link_workaround"
Test Plan

Verified no warnings with igor and mandoc

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 37151
Build 34040: arc lint + arc unit

Event Timeline

yuripv added inline comments.
share/man/man4/axp.4
150

This should be documented in LOADER TUNABLES section then.

154–155
161–162
161–162

This sentence should be first in description.

161–162

This seems to be redundant and stating obvious.

161–162
169

Let's name it consistently.

172

It was already said that it is workaround.

It may also help to use these commands (available on freefall) to look for style issues

$ mandoc -Tlint manpage.8
$ igor manpage.8

@vmaffione, I have used igor and mandoc to ensure no warnings before submitting the patch. I have informed the same in Test plan section

share/man/man4/axp.4
150

Added LOADER TUNABLES section and moved this variable there.

161–162

Removed these two lines.

rajeshasp marked 2 inline comments as done.

Addressed review comments on v1 patch

share/man/man4/axp.4
167

I would rephrase to remove the word "test". Perhaps something like "To use netmap with this device, split header support must be disabled (set this variable to 0)"

Addressed comments on V2 patch

@vmaffione, @gallatin and @yuripv,

Comments so far has been addressed. Please let me know if there are any other comments.

This revision is now accepted and ready to land.Feb 19 2021, 7:02 AM
gbe added a subscriber: gbe.

Also LGTM from manpages.

Thanks everyone for accepting the changes.

This revision was automatically updated to reflect the committed changes.