Page MenuHomeFreeBSD

ddb: reliably fail with ambiguous commands
ClosedPublic

Authored by rlibby on Feb 14 2021, 12:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 13, 3:59 AM
Unknown Object (File)
Fri, Apr 12, 9:56 AM
Unknown Object (File)
Jan 14 2024, 4:28 PM
Unknown Object (File)
Dec 22 2023, 10:39 PM
Unknown Object (File)
Dec 20 2023, 11:43 AM
Unknown Object (File)
Dec 6 2023, 4:01 AM
Unknown Object (File)
Dec 2 2023, 7:10 AM
Unknown Object (File)
Aug 28 2023, 8:26 PM
Subscribers

Details

Summary

db_cmd_match had an even/odd bug, where if a third command was partially
matched (or any odd number greater than one) the search result would be
set back from CMD_AMBIGUOUS to CMD_FOUND, causing the last command in
the list to be executed instead of failing the match.

Test Plan
# sysctl debug.kdb.enter=1
debug.kdb.enter:KDB: enter: sysctl debug.kdb.enter
 [ thread pid 895 tid 100225 ]
Stopped at      kdb_sysctl_enter+0x95:  movq    $0,0x128d790(%rip)
db> show a 
Ambiguous
db> show b
Ambiguous
db> show c
Ambiguous
db> show d
Ambiguous
db> show f
Ambiguous
db> show i
Ambiguous

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 36981
Build 33870: arc lint + arc unit