Page MenuHomeFreeBSD

ddb: reliably fail with ambiguous commands
ClosedPublic

Authored by rlibby on Feb 14 2021, 12:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 9, 4:51 PM
Unknown Object (File)
Tue, Sep 29, 5:31 PM
Unknown Object (File)
Tue, Sep 29, 5:30 PM
Unknown Object (File)
Tue, Sep 29, 3:42 PM
Unknown Object (File)
Fri, Sep 25, 9:44 AM
Unknown Object (File)
Sep 10 2026, 11:39 AM
Unknown Object (File)
Sep 8 2026, 1:21 PM
Unknown Object (File)
Sep 8 2026, 4:50 AM
Subscribers

Details

Summary

db_cmd_match had an even/odd bug, where if a third command was partially
matched (or any odd number greater than one) the search result would be
set back from CMD_AMBIGUOUS to CMD_FOUND, causing the last command in
the list to be executed instead of failing the match.

Test Plan
# sysctl debug.kdb.enter=1
debug.kdb.enter:KDB: enter: sysctl debug.kdb.enter
 [ thread pid 895 tid 100225 ]
Stopped at      kdb_sysctl_enter+0x95:  movq    $0,0x128d790(%rip)
db> show a 
Ambiguous
db> show b
Ambiguous
db> show c
Ambiguous
db> show d
Ambiguous
db> show f
Ambiguous
db> show i
Ambiguous

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable