Page MenuHomeFreeBSD
Differential D28601

netgraph/ng_bridge: Avoid cache thrashing
ClosedPublic
Actions

Authored by donner on Feb 11 2021, 11:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 1, 8:58 PM
Unknown Object (File)
Nov 25 2024, 6:46 PM
Unknown Object (File)
Nov 25 2024, 2:23 PM
Unknown Object (File)
Nov 23 2024, 7:11 AM
Unknown Object (File)
Nov 21 2024, 11:08 AM
Unknown Object (File)
Nov 20 2024, 6:01 PM
Unknown Object (File)
Nov 19 2024, 3:50 PM
Unknown Object (File)
Nov 14 2024, 2:19 PM
View All 82 Files
Subscribers
imp
melifaro
zec

Details

Reviewers
zec
Group Reviewers
network
Commits
rG83a8e97fd3c2: netgraph/ng_bridge: Avoid cache thrashing
rG7fd88ba72eb3: netgraph/ng_bridge: Avoid cache thrashing
rG4dfe70fdbda0: netgraph/ng_bridge: Avoid cache thrashing
Summary

Hint the compiler, that the branch is taken at most once per second.
Only in this case the memory line needs to be written. This will
reduce the amount of cache trashing during forward of most frames.

Suggested by: @zec

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39167
Build 36056: arc lint + arc unit

Event Timeline

donner created this revision.Feb 11 2021, 11:12 PM
Herald added subscribers: melifaro, imp. · View Herald TranscriptFeb 11 2021, 11:12 PM
donner requested review of this revision.Feb 11 2021, 11:12 PM
Harbormaster completed remote builds in B36913: Diff 83723.Feb 11 2021, 11:13 PM
donner retitled this revision from netgraph&/ng_bridge: Avoid cache thrashing to netgraph/ng_bridge: Avoid cache thrashing.Feb 11 2021, 11:13 PM
donner added a reviewer: network.
donner updated this revision to Diff 89143.May 13 2021, 4:39 PM

Rebase after other changes.

Harbormaster completed remote builds in B39167: Diff 89143.May 13 2021, 4:39 PM
zec accepted this revision.May 13 2021, 5:00 PM
This revision is now accepted and ready to land.May 13 2021, 5:00 PM
Closed by commit rG4dfe70fdbda0: netgraph/ng_bridge: Avoid cache thrashing (authored by donner). · Explain WhyMay 13 2021, 7:18 PM
This revision was automatically updated to reflect the committed changes.
donner added a commit: rG4dfe70fdbda0: netgraph/ng_bridge: Avoid cache thrashing.
donner added a commit: rG7fd88ba72eb3: netgraph/ng_bridge: Avoid cache thrashing.May 27 2021, 10:59 AM
donner added a commit: rG83a8e97fd3c2: netgraph/ng_bridge: Avoid cache thrashing.May 27 2021, 11:08 AM

Revision Contents
Changeset List

PathSize
sys/
netgraph/
3 lines

Diff 89143

View Options

sys/netgraph/ng_bridge.c

Loading...