Page MenuHomeFreeBSD

usr.sbin/makefs: fix use-after-free in read_mtree_keywords()
ClosedPublic

Authored by arichardson on Feb 10 2021, 12:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 3 2024, 10:49 AM
Unknown Object (File)
Dec 31 2023, 10:34 AM
Unknown Object (File)
Dec 22 2023, 10:26 PM
Unknown Object (File)
Dec 14 2023, 8:17 PM
Unknown Object (File)
Nov 26 2023, 2:48 AM
Unknown Object (File)
Nov 24 2023, 11:15 AM
Unknown Object (File)
Nov 20 2023, 8:17 AM
Unknown Object (File)
Nov 8 2023, 8:11 AM
Subscribers

Details

Summary

The st variable is used as a shortcut for &node->inode->st, but in one
branch just before the exit we update node->inode without changing st.

Not sure which of the two approaches is preferable

Reported by: AddressSanitizer

Test Plan

ASan no longer complains.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

usr.sbin/makefs/mtree.c
786–787

I think I like this one slightly better

LGTM. I'd probably not use "avoid UAF" in the comment though, we are resetting st because it has been invalidated by freeing node->inode

This revision is now accepted and ready to land.Feb 10 2021, 3:07 PM

Update comment and use first approach

This revision now requires review to proceed.Feb 10 2021, 3:12 PM
This revision is now accepted and ready to land.Feb 10 2021, 3:13 PM