Page MenuHomeFreeBSD

readelf: Fix printing NT_FREEBSD_ARCH_TAG
ClosedPublic

Authored by arichardson on Feb 3 2021, 2:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 6, 9:55 AM
Unknown Object (File)
Thu, Sep 25, 5:12 PM
Unknown Object (File)
Thu, Sep 25, 12:14 PM
Unknown Object (File)
Wed, Sep 24, 11:39 PM
Unknown Object (File)
Sep 5 2025, 11:18 PM
Unknown Object (File)
Aug 22 2025, 5:55 AM
Unknown Object (File)
Aug 11 2025, 9:00 PM
Unknown Object (File)
Jul 29 2025, 7:40 AM
Subscribers

Details

Summary

Looking at lib/csu/arm/crt1_s.S, this should be a string and therefore the
restriction to 4 characters seems wrong.
Found whle updating https://reviews.llvm.org/D74393.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Introduced in rS343669, looks like partial copy-paste from the other note types.

contrib/elftoolchain/readelf/readelf.c
3744

Cast is unnecessary?

This revision is now accepted and ready to land.Feb 3 2021, 3:04 PM
contrib/elftoolchain/readelf/readelf.c
3744

A yes, for some reason I thought it was a uint8_t *. Will remove before committing.

This revision was automatically updated to reflect the committed changes.
arichardson marked an inline comment as done.