Page MenuHomeFreeBSD
Differential D28470

readelf: Fix printing NT_FREEBSD_ARCH_TAG
ClosedPublic
Actions

Authored by arichardson on Feb 3 2021, 2:49 PM.
Tags
None
Referenced Files
F103149628: D28470.diff
Thu, Nov 21, 3:35 PM
Unknown Object (File)
Wed, Nov 20, 10:12 AM
Unknown Object (File)
Mon, Nov 18, 7:13 PM
Unknown Object (File)
Mon, Nov 18, 5:23 AM
Unknown Object (File)
Sun, Nov 17, 5:31 PM
Unknown Object (File)
Thu, Nov 14, 9:07 PM
Unknown Object (File)
Mon, Nov 11, 10:41 AM
Unknown Object (File)
Mon, Nov 11, 10:02 AM
View All 58 Files
Subscribers
imp

Details

Reviewers
emaste
brooks
kib
dim
Commits
rGab0e7589d26b: readelf: Fix printing NT_FREEBSD_ARCH_TAG
rG2a39919364b5: readelf: Fix printing NT_FREEBSD_ARCH_TAG
Summary

Looking at lib/csu/arm/crt1_s.S, this should be a string and therefore the
restriction to 4 characters seems wrong.
Found whle updating https://reviews.llvm.org/D74393.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arichardson created this revision.Feb 3 2021, 2:49 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 3 2021, 2:49 PM
arichardson requested review of this revision.Feb 3 2021, 2:49 PM
Harbormaster completed remote builds in B36688: Diff 83310.Feb 3 2021, 2:49 PM
emaste accepted this revision.Feb 3 2021, 3:04 PM

Introduced in rS343669, looks like partial copy-paste from the other note types.

contrib/elftoolchain/readelf/readelf.c
3744

Cast is unnecessary?

This revision is now accepted and ready to land.Feb 3 2021, 3:04 PM
arichardson added inline comments.Feb 3 2021, 3:06 PM
contrib/elftoolchain/readelf/readelf.c
3744

A yes, for some reason I thought it was a uint8_t *. Will remove before committing.

Closed by commit rG2a39919364b5: readelf: Fix printing NT_FREEBSD_ARCH_TAG (authored by arichardson). · Explain WhyFeb 3 2021, 4:06 PM
This revision was automatically updated to reflect the committed changes.
arichardson marked an inline comment as done.
arichardson added a commit: rG2a39919364b5: readelf: Fix printing NT_FREEBSD_ARCH_TAG.
arichardson added a commit: rGab0e7589d26b: readelf: Fix printing NT_FREEBSD_ARCH_TAG.Mar 17 2021, 10:29 AM

Revision Contents
Changeset List

PathSize
contrib/
elftoolchain/
readelf/
4 lines

Diff 83315

View Options

contrib/elftoolchain/readelf/readelf.c

Loading...