Page MenuHomeFreeBSD

readelf: Fix printing NT_FREEBSD_ARCH_TAG
ClosedPublic

Authored by arichardson on Wed, Feb 3, 2:49 PM.

Details

Summary

Looking at lib/csu/arm/crt1_s.S, this should be a string and therefore the
restriction to 4 characters seems wrong.
Found whle updating https://reviews.llvm.org/D74393.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Introduced in rS343669, looks like partial copy-paste from the other note types.

contrib/elftoolchain/readelf/readelf.c
3744

Cast is unnecessary?

This revision is now accepted and ready to land.Wed, Feb 3, 3:04 PM
contrib/elftoolchain/readelf/readelf.c
3744

A yes, for some reason I thought it was a uint8_t *. Will remove before committing.

This revision was automatically updated to reflect the committed changes.
arichardson marked an inline comment as done.