readelf: Fix printing NT_FREEBSD_ARCH_TAG
ClosedPublic
Actions

Authored by arichardson on Wed, Feb 3, 2:49 PM.

Details

Reviewers

emaste
brooks
kib
dim

Commits

R10:2a39919364b5: readelf: Fix printing NT_FREEBSD_ARCH_TAG

Summary

Looking at lib/csu/arm/crt1_s.S, this should be a string and therefore the
restriction to 4 characters seems wrong.
Found whle updating https://reviews.llvm.org/D74393.

Diff Detail

Repository

R10 FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

arichardson created this revision.Wed, Feb 3, 2:49 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Feb 3, 2:49 PM

arichardson requested review of this revision.Wed, Feb 3, 2:49 PM

Harbormaster completed remote builds in B36688: Diff 83310.Wed, Feb 3, 2:49 PM

Introduced in rS343669, looks like partial copy-paste from the other note types.

contrib/elftoolchain/readelf/readelf.c
3744	Cast is unnecessary?

This revision is now accepted and ready to land.Wed, Feb 3, 3:04 PM

arichardson added inline comments.Wed, Feb 3, 3:06 PM

contrib/elftoolchain/readelf/readelf.c
3744	A yes, for some reason I thought it was a `uint8_t *`. Will remove before committing.

Closed by commit R10:2a39919364b5: readelf: Fix printing NT_FREEBSD_ARCH_TAG (authored by arichardson). · Explain WhyWed, Feb 3, 4:06 PM

This revision was automatically updated to reflect the committed changes.

arichardson marked an inline comment as done.

arichardson added a commit: R10:2a39919364b5: readelf: Fix printing NT_FREEBSD_ARCH_TAG.

Revision Contents
Changeset List

Path

Size

contrib/

elftoolchain/

readelf/

readelf.c

4 lines

Diff 83315

View Options

contrib/elftoolchain/readelf/readelf.c

readelf: Fix printing NT_FREEBSD_ARCH_TAGClosedPublicActions