Page MenuHomeFreeBSD

readelf: Fix printing NT_FREEBSD_ARCH_TAG
ClosedPublic

Authored by arichardson on Feb 3 2021, 2:49 PM.
Tags
None
Referenced Files
F80133722: D28470.diff
Thu, Mar 28, 9:03 AM
Unknown Object (File)
Feb 24 2024, 12:13 PM
Unknown Object (File)
Feb 7 2024, 4:15 AM
Unknown Object (File)
Dec 28 2023, 10:11 AM
Unknown Object (File)
Dec 27 2023, 2:11 AM
Unknown Object (File)
Dec 11 2023, 7:33 AM
Unknown Object (File)
Nov 21 2023, 12:08 AM
Unknown Object (File)
Oct 11 2023, 4:59 PM
Subscribers

Details

Summary

Looking at lib/csu/arm/crt1_s.S, this should be a string and therefore the
restriction to 4 characters seems wrong.
Found whle updating https://reviews.llvm.org/D74393.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Introduced in rS343669, looks like partial copy-paste from the other note types.

contrib/elftoolchain/readelf/readelf.c
3744

Cast is unnecessary?

This revision is now accepted and ready to land.Feb 3 2021, 3:04 PM
contrib/elftoolchain/readelf/readelf.c
3744

A yes, for some reason I thought it was a uint8_t *. Will remove before committing.

This revision was automatically updated to reflect the committed changes.
arichardson marked an inline comment as done.