Drop support for FreeBSD 12.1 which will reach end-of-life on 2021-02-01.
ClosedPublic
Actions

Authored by rene on Jan 28 2021, 10:01 PM.

Details

Reviewers

naddy
jbeich
jhale
mandree
mikael
osa
sunpoet
mat

Group Reviewers

portmgr
emulation

Commits

rP563570: Remove support for FreeBSD 12.1 from various ports.

Summary

The HEAD branch will receive the entire modification, 2021Q1 will only
receive the change to Mk/bsd.port.mk

Some ports that would require updates are excluded (e.g. lang/rust-bootstrap
or misc/freebsd-release-manifests)

Test Plan

make index

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rene created this revision.Jan 28 2021, 10:01 PM

Herald added a reviewer: portmgr. · View Herald TranscriptJan 28 2021, 10:01 PM

Herald added subscribers: jonathan, mat. · View Herald Transcript

rene requested review of this revision.Jan 28 2021, 10:01 PM

Harbormaster completed remote builds in B36585: Diff 83071.Jan 28 2021, 10:01 PM

rene added reviewers: emulation, naddy, jbeich, jhale, mandree, mikael, osa, sunpoet.Jan 28 2021, 10:11 PM

Looks good to me for lang/luajit/Makefile.

Two inline comments, else no objections from me, but no complete review either (I checked those areas I maintain and skimmed the others only cursorily. Nothing striking out as unacceptable though.)

graphics/rawtherapee/Makefile
40 ↗	(On Diff #83071)	LGTM. Change on this line is approved.
lang/luajit/Makefile
35 ↗	(On Diff #83071)	Can and should such lore be preserved for posterity (Wiki) somewhere, so we have historic references and can reconstruct "why we did this" without digging out tons of archives later? Or are LLVM 8.x now all extinct?

mat accepted this revision.Jan 29 2021, 8:52 AM

This revision is now accepted and ready to land.Jan 29 2021, 8:52 AM

rene mentioned this in D28416: Rebase on r563222 Drop support for FreeBSD 12.1.Jan 29 2021, 7:01 PM

Rebase on r563222

bsd.port.mk: Drop support for FreeBSD 12.1
Cleanup 1201
Cleanup 12\\.1

This revision now requires review to proceed.Jan 29 2021, 7:15 PM

Harbormaster completed remote builds in B36611: Diff 83117.Jan 29 2021, 7:16 PM

jbeich added inline comments.Jan 29 2021, 8:12 PM

emulators/rpcs3/Makefile

83 ↗

(On Diff #83117)

Don't remove this line yet. Upstream no longer supports LLVM_DEFAULT=90, so the port bumps it without compromising DEFAULT_VERSIONS += llvm=12 (or llvm=-devel).

$ poudriere testport -j 122amd64 emulators/rpcs3
[...]
=======================<phase: check-sanity   >============================
/!\ ERRORS /!\

The variable LLVM_DEFAULT is set and it should only be defined through
DEFAULT_VERSIONS+=llvm=11 in /etc/make.conf

*** Error code 1