Page MenuHomeFreeBSD

[porters-handbook]: Clarify prefixes in patch file names
ClosedPublic

Authored by fernape on Jan 21 2021, 11:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 11:49 PM
Unknown Object (File)
Sun, Apr 7, 11:20 PM
Unknown Object (File)
Mar 31 2024, 6:38 AM
Unknown Object (File)
Mar 14 2024, 11:37 AM
Unknown Object (File)
Mar 13 2024, 3:09 PM
Unknown Object (File)
Mar 13 2024, 2:39 AM
Unknown Object (File)
Mar 4 2024, 11:47 PM
Unknown Object (File)
Jan 14 2024, 10:43 PM

Details

Summary

Patches must start with patch- in order to be applied automatically.
Conditional patches must not start with patch-.

PR: 249038
Reported by: pauamma@gundo.com

Test Plan
  • igor clean
  • page renders properly

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 36535
Build 33424: arc lint + arc unit

Event Timeline

0mp requested changes to this revision.Apr 18 2021, 1:48 PM

Otherwise, it's a good change!

documentation/content/en/books/porters-handbook/slow-porting/chapter.adoc
215

Also, maybe start the sentence on a new line? I'm not sure what the style guide is at the moment.

216
217

We usually try to avoid "you" in documentation.

This revision now requires changes to proceed.Apr 18 2021, 1:48 PM

Address suggestions by 0mp:

Note that all the previous changes have gone away in Phabricator because the file name changed from _chapter.adoc to _index.adoc which is what we always use from now on.

Almost there!

documentation/content/en/books/porters-handbook/slow-porting/_index.adoc
214 ↗(On Diff #87662)

Suggestion: maybe we can simplify this sentence further like this.

  • Simplify sentence

    Suggested by 0mp. Use present tense.
fernape added inline comments.
documentation/content/en/books/porters-handbook/slow-porting/_index.adoc
214 ↗(On Diff #87662)

Easier to read. Thanks!

Thanks! Let's get it into the tree!

This revision was not accepted when it landed; it landed in state Needs Review.Apr 20 2021, 9:47 AM
This revision was automatically updated to reflect the committed changes.
fernape marked an inline comment as done.