Page MenuHomeFreeBSD
Differential D28246

Further refactor IPv4 interface route creation.
ClosedPublic
Actions

Authored by melifaro on Jan 19 2021, 11:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 2, 3:14 PM
Unknown Object (File)
Sun, Dec 1, 6:43 PM
Unknown Object (File)
Nov 25 2024, 8:09 PM
Unknown Object (File)
Nov 25 2024, 2:24 PM
Unknown Object (File)
Nov 24 2024, 7:01 PM
Unknown Object (File)
Nov 23 2024, 6:53 PM
Unknown Object (File)
Nov 23 2024, 4:13 PM
Unknown Object (File)
Nov 23 2024, 4:23 AM
View All Files
Subscribers
dch
donner
flo
imp

Details

Reviewers
donner
Group Reviewers
network
Commits
rG130aebbab0d3: Further refactor IPv4 interface route creation.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 36378
Build 33267: arc lint + arc unit

Event Timeline

melifaro created this revision.Jan 19 2021, 11:51 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 19 2021, 11:51 PM
melifaro requested review of this revision.Jan 19 2021, 11:51 PM
Harbormaster completed remote builds in B36352: Diff 82595.Jan 19 2021, 11:51 PM
melifaro added a reviewer: network.Jan 19 2021, 11:52 PM
donner added a subscriber: donner.Jan 20 2021, 7:59 AM
donner added inline comments.
sys/netinet/in.c
769

The comment is misleading. This function checks, if the IP address on the interface is singular enough to add an additional loopback route for the local host in the attached network,

Of course, all excluded cases do need a loopback route, too. But not an extra one,

flo added a subscriber: flo.Jan 20 2021, 6:23 PM
melifaro updated this revision to Diff 82655.Jan 20 2021, 9:28 PM

Update comments.

Harbormaster completed remote builds in B36377: Diff 82655.Jan 20 2021, 9:28 PM
melifaro added inline comments.Jan 20 2021, 9:32 PM
sys/netinet/in.c
769

Indeed, there is a clash for the "loopback" term. We will always install some loopback route, the question is whether we install it via ifa_maintain_loopback_route() or not.
In the end, we should unify both "loopback" and "prefix" route handling, but it's too late to untangle in 13.

Anyway, I've updated the description, hope it looks more clear now.

melifaro updated this revision to Diff 82656.Jan 20 2021, 9:38 PM

Remove in_addprefix() now-unused flags argument.

Harbormaster completed remote builds in B36378: Diff 82656.Jan 20 2021, 9:38 PM
melifaro updated this revision to Diff 82659.Jan 20 2021, 10:05 PM

.

Harbormaster completed remote builds in B36379: Diff 82659.Jan 20 2021, 10:05 PM
donner accepted this revision as: donner.Jan 21 2021, 7:01 AM
This revision is now accepted and ready to land.Jan 21 2021, 7:01 AM
dch added a subscriber: dch.Jan 21 2021, 3:38 PM

this diff fixes https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252883 thanks can you mention the PR when this patch gets merged? thanks!

Closed by commit rG130aebbab0d3: Further refactor IPv4 interface route creation. (authored by melifaro). · Explain WhyJan 21 2021, 9:49 PM
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rG130aebbab0d3: Further refactor IPv4 interface route creation..

Revision Contents
Changeset List

PathSize
sys/
netinet/
235 lines
2 lines
2 lines

Diff 82656

View Options

sys/netinet/in.c

Loading...
View Options

sys/netinet/in_var.h

Loading...
View Options

sys/netinet/ip_carp.c

Loading...